Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider CacheKey always when searching, handle null string gracefully in Distributed cache. #21

Closed

Conversation

SOFSPEEL
Copy link

The CacheKey was not being considered when looking for saved cache items in _cachingMethodsSet.

As such it may even be pointless to save stuff in _cachingMethodsSet, consider just getting rid of it.

@JeremyBP
Copy link
Contributor

JeremyBP commented May 2, 2024

Thanks for your contribution.
I ended up deleting the final line where I was adding the cachekey to the methodset in such parameter based cachekey scenario.
This way I keep the methodset benefits at first place for all other scenarios, including no cache, or cache but no parameter.
Again thank you very much for your engagement!

@JeremyBP JeremyBP closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants