Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching namespaced references #51

Closed
alganet opened this issue Jan 30, 2015 · 3 comments
Closed

Matching namespaced references #51

alganet opened this issue Jan 30, 2015 · 3 comments
Labels

Comments

@alganet
Copy link
Member

alganet commented Jan 30, 2015

Problem:

[instanceof Foo\Bar]
baz = something

[lorem Foo\Ipsum]
baz = [Foo\Bar] ; not a valid name

Quick Fix:

    protected function matchReference(&$value)
    {
        if (preg_match('/^\[([[:alnum:]\\\\]+)\]$/', $value, $match)) {
            return (boolean) ($value = $match[1]);
        }
    }

Still digging the problem.

@alganet alganet added the bug label Jan 30, 2015
alganet pushed a commit to alganet/Config that referenced this issue Feb 11, 2015
  - Dependency solver was removed (it wasnt done).
  - Timezone issue with testing solved.
  - Tests for Issue Respect#40 don't display the expected bug.
  - Fixes Respect#50 and Respect#51
alganet pushed a commit that referenced this issue Feb 11, 2015
Closes #40 (test passes), fixes #50 and #51.
@jackmakiyama
Copy link
Contributor

@alganet PR #52 fixes this issue? Can you close this issue please?

/cc @henriquemoody

@henriquemoody
Copy link
Member

Thanks for reporting, @jackmakiyama

@jackmakiyama
Copy link
Contributor

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants