Change docblocks to reflect magic static methods

[rizqidjamaluddin]

Some IDEs use a class' @method docblock annotations to autocomplete, suggest and typehint magic methods for users. The validator.php class has these, but doesn't mark them as static, so the suggested V::method() syntax continuously throws errors:

IDE I'm using is PHPStorm 7.1.3 (latest as of writing).

It appears that adding static annotations doesn't affect normal (dynamic) calls because PHP is okay with calling statics normally. Clearly the other way around doesn't seem to work!

(I noticed a similar request from long ago - I apologize if there's already a rationale for not doing this.)

[augustohp]

Hey, thanks to your feedback and pull request! 🍻

Have you tested your pull requested code on other largely used IDEs (Eclipse PDT, Zend Studio, Netbeans), does this affect the behavior of autocomplete on them?

[alganet]

I guess we did those docblock tags right after PHP 5.3 (and __callStatic) was released and we focused on the __call only cause no IDE supported static magic docs back then. It will probably work fine as static now.

Calls from incompatible contexts were banned in 5.6 though, so we may need to add two lines of docs for each rule (one static and one for the instance). It seems that phpDocumentor2 will set the standard for those. They're discussing a format that could save us a lot of lines

[rizqidjamaluddin]

I admit that I haven't checked with other IDEs, so I'm hoping any users who use those can confirm/deny if it works in their respective environments. I think (sans problems with incompatible contexts) any spec-compliant IDE shouldn't have a problem with this, but I absolutely understand the concerns!

Would having both lines cause any problems? I imagine not, unless some IDE thinks it's declaring each method twice somehow.

[appinteractive]

Hey there, please merge this pull request (it's 6 months now), it's not really usable without this in PhpStorm! It shouldn't break anything since its quite obvious to specify the static key there. I like this library but its not very well maintained. :(

[henriquemoody]

I'm sorry by our late. Seems like there is a lot of people complaining about that, we just discuss it on #202 2 hours ago. In fact we cannot use only static declarations since you can use it in chains, but the best think to do, IMO is create 2 declarations for every rule, what you guys think about it?

[henriquemoody]

Actually, when a method is static it can me used as non-static, so the static must work for both.