Electrical Wiring: Pinch Valve Harness

[inceptionev]

Description

This PR creates the definition and instructions for making the pinch valve harness.

Closes #1284

Self-review checklist:

• Self-review: looked through the Files changed tab, browsed repository in branch

• Documentation updated - reflects changes in code, electrical or mechanical design

• Documentation and graphics follow the documentation style guide

• New content is linked, easily discoverable, does not require too many clicks

• Follows other relevant parts of contributor wiki

• PR has a descriptive name

• Tagged relevant reviewers

• Follows our mechanical engineering standards

• Everything is metric and ISO where possible

• All features and constraints are named

• Imported parts are well-named, with source URL and iProperties

• Screenshots and/or assembly photos updated

[codecov]

Codecov Report

Merging #1336 (b448d3b) into master (8154de8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1336   +/-   ##
=======================================
  Coverage   57.53%   57.53%           
=======================================
  Files         102      102           
  Lines        3471     3471           
  Branches      321      321           
=======================================
  Hits         1997     1997           
  Misses       1474     1474           

Flag	Coverage Δ
common	95.90% <ø> (ø)
controller	57.37% <ø> (ø)
gui	29.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[martukas]

When building this locally, I get the following errors related to the wiring docs:

docs/wiring/oxygen_sensor.rst:4: WARNING: duplicate label oxygen sensor harness, other instance in docs/wiring/oxygen_sensor.rst
docs/wiring/pinch_valve.rst:4: WARNING: duplicate label pinch valve harness, other instance in docs/wiring/pinch_valve.rst

There is the .. _Pinch Valve Harness which is not rendered but only used for reference links. The section name that looks like this:

Pinch Valve Harness
======================

constitutes the document name and is also taken up by sphinx as a xref identifier. If the latter is enough thee is no need for the former. See blower for a case where they are different, and in that case it probably makes sense.

And also

docs/wiring/blower_TK_BA7050H12B.rst:12: WARNING: undefined label: included-with-blower
docs/wiring/pinch_valve.rst:12: WARNING: undefined label: included-with-motor

I understand the issue, but not sure how we would want this to ideally function? Should it still link to the blower/motor item in the BOM somehow? If not, should they at least render nicer? What would do we want them to say on the table? If we expect to have similar but not identical opt-out/dummy part numbers, how should they be identified by the script as not needing a link? Perhaps you could create a ticket with a feature request for improvement to the docs script? If some answers to the above questions are not obvious, we could have a small discussion to hone in on what is needed.

[martukas]

Perhaps like we did for the power harness, we could also include an alternate pre-crimped wires?
In this case I got these:
https://www.digikey.com/short/94m2z0bw

[martukas]

The 1m wire length is empirically what comes with the stepper. Now examining the enclocure it looks like at the worst case (valve at opposite corner from the connector, taking some non-straight-line path) it should be no more than 70cm, probably less when we finalize it. We could also create a ticket to make a final revision of harness lengths prior to final release of 0.4.

[martukas]

Looks like 4mm diameter shrink tubing might be more appropriate here, unless we are talking solder joints to pre-crimped tails, in which case yes 5mm.

[martukas]

And I used maybe 6-7 pieces of shrink tubing. The stepper wires are pretty twisty and capricious.

[martukas]

I have managed to make it. Notes from the process are provided above as comments on the PR. I don't think the changes I am requesting are very significant and you are welcome to evade them or postpone them via new tickets, for example.
Anyway, the only aspect of this that I cannot verify is whether the wire mappings are correct without a working HAL. The STMduino code rotates the stepper about 180 degrees clockwise at a slow pace, so that is tentatively something.