Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require default length in sizes (authoring req) #256

Closed
zcorpan opened this issue Feb 8, 2015 · 4 comments
Closed

Require default length in sizes (authoring req) #256

zcorpan opened this issue Feb 8, 2015 · 4 comments

Comments

@zcorpan
Copy link

@zcorpan zcorpan commented Feb 8, 2015

See #253

since we require the sizes attribute now because defaulting to 100vw is unexpected, do we also want to require a default length for the same resaon?

maybe people will write media-conditions that are mutually exclusive, in which case a default length is not needed ? We could make it a parse error if the algorithm falls back to 100vw.

@zcorpan
Copy link
Author

@zcorpan zcorpan commented Feb 10, 2015

I'm leaning towards the simplest option, change the grammar to require the default length.

@yoavweiss
Copy link
Member

@yoavweiss yoavweiss commented Feb 10, 2015

If we're changing the grammar, it'd also change the processing model, not just the authoring requirements, right?

What should the browser do if the default length is not there?

@zcorpan
Copy link
Author

@zcorpan zcorpan commented Feb 11, 2015

No need to change the processing model.

@yoavweiss
Copy link
Member

@yoavweiss yoavweiss commented Feb 13, 2015

OK

@zcorpan zcorpan closed this in 2340eca Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.