Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS attack <script>console.warm('pwned')</script> #21

Closed
marcoscaceres opened this issue Nov 13, 2012 · 8 comments
Closed

XSS attack <script>console.warm('pwned')</script> #21

marcoscaceres opened this issue Nov 13, 2012 · 8 comments

Comments

@marcoscaceres
Copy link
Contributor

Because we were not sanitizing the titles of Github bugs, we left ourselves open to a XSS attack. @marcoscaceres tried to fix this with:

htmlspecialchars($var, ENT_QUOTES, 'UTF-8').

But he is no PHP security expert.

@marcoscaceres
Copy link
Contributor Author

Need to fix this ASAP

@marcoscaceres
Copy link
Contributor Author

Ok, I think I fixed it with: htmlspecialchars($var, ENT_QUOTES, 'UTF-8').

However, need security review.

@marcoscaceres
Copy link
Contributor Author

testing again

@marcoscaceres
Copy link
Contributor Author

Seems ok now, but would really like a proper review. Maybe @attiks can do it or knows someone? The file in question is: https://github.com/ResponsiveImagesCG/responsiveimages.org/blob/master/issues.php#L86 (print_issues() function)

@attiks
Copy link
Member

attiks commented Nov 13, 2012

did you push the latest changes?

@marcoscaceres
Copy link
Contributor Author

ah, my bad. I did not. I only pushed to the website... pushing now.

@marcoscaceres
Copy link
Contributor Author

@attiks
Copy link
Member

attiks commented Nov 13, 2012

That should do it.

@attiks attiks closed this as completed Nov 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants