Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the allowed characters when registering a number #2371

Open
ammendonca opened this issue Jul 19, 2017 · 2 comments
Open

Limit the allowed characters when registering a number #2371

ammendonca opened this issue Jul 19, 2017 · 2 comments
Assignees

Comments

@ammendonca
Copy link
Contributor

When registering a number we should perform validation at the API level, not all characters should be allowed (we should only allow what we want and reject anything else).

For instance is possible to register $ as a number and after that it's not possible to register additional fully numeric numbers and in the server logs, we can see 15:41:48,807 INFO [org.restcomm.connect.dao.mybatis.MybatisIncomingPhoneNumbersDao] (http-/127.0.0.1:8080-7) Pattern "$" matched the phone number "432423", so it seems to be messing with the regex for existing numbers.

@meghnatolani
Copy link

Hi, can I work on this bug?

@ammendonca
Copy link
Contributor Author

@meghnatolani yes, please. Let me know if you need more clarification on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants