Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String.intern is consuming too much CPU #13

Open
jaimecasero opened this issue Nov 2, 2015 · 0 comments
Open

String.intern is consuming too much CPU #13

jaimecasero opened this issue Nov 2, 2015 · 0 comments
Assignees
@jaimecasero
Labels
enhancement

Comments

@jaimecasero
Copy link
Contributor

after profiling sessions a hotspot was identified in String.intern. Apparently the lookup cost is high
@jaimecasero jaimecasero self-assigned this Nov 2, 2015
jaimecasero added a commit to jaimecasero/jain-sip that referenced this issue Nov 2, 2015
@jaimecasero
fix for RestComm#13
f5d0569
jaimecasero added a commit to jaimecasero/jain-sip that referenced this issue Nov 4, 2015
@jaimecasero
fix for RestComm#13
c4f9fac
@deruelle deruelle modified the milestone: 2.0.0 Nov 10, 2015
jaimecasero added a commit to jaimecasero/jain-sip that referenced this issue Nov 24, 2015
@jaimecasero
fix for RestComm#13
16e192d
@jaimecasero jaimecasero removed this from the 2.0.0 milestone Jun 9, 2016
xhoaluu pushed a commit that referenced this issue Oct 31, 2016
@ranganathanm @xhoaluu
Merge pull request #13 from eface2face/master
c3e09df 
Fix right byte order in frame length encoding
AlerantAppNGIN pushed a commit to AlerantAppNGIN/jain-sip that referenced this issue May 19, 2017
Got rid of String.intern()
b1a0b8a 
Rationale: too much CPU overhead, see Restcomm issue RestComm#13. The String objects in question are never compared with ==, so it's safe to remove the intern() call.
@TristanPerry TristanPerry mentioned this issue Jan 16, 2020
Open
deruelle referenced this issue in mobius-software-ltd/corsac-sip Jan 19, 2024
@ranganathanm @xhoaluu
Merge pull request #13 from eface2face/master
03bf1b8 
Fix right byte order in frame length encoding

Conflicts:
	src/gov/nist/javax/sip/stack/WebSocketCodec.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaimecasero jaimecasero

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deruelle @jaimecasero