add tests #258 (allow TCAP user specify ability to skip protocol vers…

…ion in dialogue portion)

tcap/tcap-impl/src/main/java/org/mobicents/protocols/ss7/tcap/asn/DialogRequestAPDUImpl.java

@@ -40,7 +40,7 @@ public class DialogRequestAPDUImpl implements DialogRequestAPDU {
 
     private ApplicationContextName acn;
     private UserInformation ui;
-    private ProtocolVersion protocolVersion = new ProtocolVersionImpl();
+    private ProtocolVersion protocolVersion = null;
     private boolean doNotSendProtocolVersion = false;
     private boolean malformedUserInformation = false;
 
@@ -204,8 +204,10 @@ public void encode(AsnOutputStream aos) throws EncodeException {
             aos.writeTag(Tag.CLASS_APPLICATION, false, _TAG_REQUEST);
             int pos = aos.StartContentDefiniteLength();
 
-            if (!doNotSendProtocolVersion)
+            if (!doNotSendProtocolVersion) {
+                this.protocolVersion = new ProtocolVersionImpl();
                 this.protocolVersion.encode(aos);
+            }
             this.acn.encode(aos);
 
             if (ui != null)

tcap/tcap-impl/src/test/java/org/mobicents/protocols/ss7/tcap/ProtocolVersionTest.java

@@ -0,0 +1,249 @@
+/*
+ * TeleStax, Open Source Cloud Communications
+ * Copyright 2012, Telestax Inc and individual contributors
+ * by the @authors tag. See the copyright.txt in the distribution for a
+ * full listing of individual contributors.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+
+package org.mobicents.protocols.ss7.tcap;
+
+import static org.testng.Assert.assertNotNull;
+import static org.testng.Assert.assertNull;
+
+import java.io.IOException;
+import org.mobicents.protocols.asn.AsnInputStream;
+import org.mobicents.protocols.ss7.indicator.RoutingIndicator;
+import org.mobicents.protocols.ss7.sccp.NetworkIdState;
+import org.mobicents.protocols.ss7.sccp.RemoteSccpStatus;
+import org.mobicents.protocols.ss7.sccp.SccpListener;
+import org.mobicents.protocols.ss7.sccp.SignallingPointStatus;
+import org.mobicents.protocols.ss7.sccp.impl.SccpHarness;
+import org.mobicents.protocols.ss7.sccp.message.SccpDataMessage;
+import org.mobicents.protocols.ss7.sccp.message.SccpNoticeMessage;
+import org.mobicents.protocols.ss7.sccp.parameter.SccpAddress;
+import org.mobicents.protocols.ss7.tcap.asn.DialogRequestAPDU;
+import org.mobicents.protocols.ss7.tcap.asn.ParseException;
+import org.mobicents.protocols.ss7.tcap.asn.ProtocolVersion;
+import org.mobicents.protocols.ss7.tcap.asn.TcapFactory;
+
+import org.mobicents.protocols.ss7.tcap.asn.comp.TCBeginMessage;
+import org.mobicents.protocols.ss7.tcap.asn.comp.TCContinueMessage;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.AfterMethod;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+/**
+ * Test for call flow.
+ *
+ * @author Nosach Konstantin
+ *
+ */
+public class ProtocolVersionTest extends SccpHarness {
+    public static final long WAIT_TIME = 500;
+    private static final int _WAIT_TIMEOUT = 90000;
+    public static final long[] _ACN_ = new long[] { 0, 4, 0, 0, 1, 0, 19, 2 };
+    private TCAPStackImpl tcapStack1;
+    private TCAPStackImpl tcapStack2;
+    private SccpAddress peer1Address;
+    private SccpAddress peer2Address;
+    private Client client;
+    private Server server;
+    private TestSccpListener sccpListener;
+    private ProtocolVersion pv;
+
+    public ProtocolVersionTest() {
+
+    }
+
+    @BeforeClass
+    public void setUpClass() {
+        this.sccpStack1Name = "TCAPFunctionalTestSccpStack1";
+        this.sccpStack2Name = "TCAPFunctionalTestSccpStack2";
+        System.out.println("setUpClass");
+    }
+
+    @AfterClass
+    public void tearDownClass() throws Exception {
+        System.out.println("tearDownClass");
+    }
+
+    /*
+     * (non-Javadoc)
+     *
+     * @see junit.framework.TestCase#setUp()
+     */
+    @BeforeMethod
+    public void setUp() throws Exception {
+        System.out.println("setUp");
+        super.setUp();
+
+        peer1Address = super.parameterFactory.createSccpAddress(RoutingIndicator.ROUTING_BASED_ON_DPC_AND_SSN, null, 1, 8);
+        peer2Address = super.parameterFactory.createSccpAddress(RoutingIndicator.ROUTING_BASED_ON_DPC_AND_SSN, null, 2, 8);
+
+        sccpListener = new TestSccpListener();
+        this.sccpProvider2.registerSccpListener(8, sccpListener);
+        this.tcapStack1 = new TCAPStackImpl("TCAPFunctionalTest", this.sccpProvider1, 8);
+        this.tcapStack2 = new TCAPStackImpl("TCAPFunctionalTest", this.sccpProvider2, 7);
+
+        this.tcapStack1.start();
+        this.tcapStack2.start();
+
+        this.tcapStack1.setInvokeTimeout(0);
+        this.tcapStack2.setInvokeTimeout(0);
+        // create test classes
+        this.client = new Client(this.tcapStack1, super.parameterFactory, peer1Address, peer2Address);
+        this.server = new Server(this.tcapStack2, super.parameterFactory, peer2Address, peer1Address);
+
+    }
+
+    /*
+     * (non-Javadoc)
+     *
+     * @see junit.framework.TestCase#tearDown()
+     */
+    @AfterMethod
+    public void tearDown() {
+        this.tcapStack1.stop();
+        this.tcapStack2.stop();
+        super.tearDown();
+
+    }
+
+    @Test(groups = { "functional.flow" })
+    public void doNotSendProtocolVersionDialogTest() throws Exception {
+
+        client.startClientDialog();
+        client.dialog.setDoNotSendProtocolVersion(true);
+        client.waitFor(WAIT_TIME);
+
+        client.sendBegin();
+        client.waitFor(WAIT_TIME);
+        assertNull(pv);
+    }
+
+    @Test(groups = { "functional.flow" })
+    public void sendProtocolVersionDialogTest() throws Exception {
+
+        client.startClientDialog();
+        client.dialog.setDoNotSendProtocolVersion(false);
+        client.waitFor(WAIT_TIME);
+
+        client.sendBegin();
+        client.waitFor(WAIT_TIME);
+        assertNotNull(pv);
+    }
+
+    @Test(groups = { "functional.flow" })
+    public void doNotSendProtocolVersionStackTest() throws Exception {
+        this.tcapStack1.setDoNotSendProtocolVersion(true);
+        client.startClientDialog();
+        client.waitFor(WAIT_TIME);
+        client.sendBegin();
+        client.waitFor(WAIT_TIME);
+        assertNull(pv);
+    }
+
+    @Test(groups = { "functional.flow" })
+    public void sendProtocolVersionStackTest() throws Exception {
+        this.tcapStack1.setDoNotSendProtocolVersion(false);
+        client.startClientDialog();
+        client.waitFor(WAIT_TIME);
+        client.sendBegin();
+        client.waitFor(WAIT_TIME);
+        assertNotNull(pv);
+    }
+
+    private class TestSccpListener implements SccpListener {
+
+        private static final long serialVersionUID = 1L;
+
+        @Override
+        public void onMessage(SccpDataMessage message) {
+            AsnInputStream ais = new AsnInputStream(message.getData());
+            TCContinueMessage tcm = null;
+            int tag;
+            try
+            {
+                tag = ais.readTag();
+
+            }
+            catch(IOException ex) {
+                try
+                {
+                    ais.close();
+                }
+                catch(IOException ex1) {
+
+                }
+
+                return;
+            }       
+
+            switch (tag) {
+                case TCBeginMessage._TAG:
+                    TCBeginMessage tcb = null;
+                    try {
+                        tcb = TcapFactory.createTCBeginMessage(ais);
+                    } catch (ParseException e) {
+
+                    }
+
+                    if(tcb!=null)
+                    {
+                        if(tcb.getDialogPortion().getDialogAPDU() instanceof DialogRequestAPDU) {
+                            pv=((DialogRequestAPDU)tcb.getDialogPortion().getDialogAPDU()).getProtocolVersion();
+                        } 
+                        System.out.println("PROTOCOL VERSION IS : " + pv);
+                    }
+                    break;
+            }      
+            try
+            {
+                ais.close();
+            }
+            catch(IOException ex1) {
+
+            }
+        }
+
+        @Override
+        public void onNotice(SccpNoticeMessage message) {
+        }
+
+        @Override
+        public void onCoordResponse(int ssn, int multiplicityIndicator) {
+        }
+
+        @Override
+        public void onState(int dpc, int ssn, boolean inService,
+                int multiplicityIndicator) {
+        }
+
+        @Override
+        public void onPcState(int dpc, SignallingPointStatus status, Integer restrictedImportanceLevel, RemoteSccpStatus remoteSccpStatus) {
+        }
+
+        @Override
+        public void onNetworkIdState(int networkId, NetworkIdState networkIdState) {
+        }
+
+    }
+
+}