Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding of MAP operation: anyTimeSubscriptionInterrogation #108

Closed
vetss opened this issue Jun 2, 2016 · 5 comments
Closed

Adding of MAP operation: anyTimeSubscriptionInterrogation #108

vetss opened this issue Jun 2, 2016 · 5 comments
Assignees
Milestone

Comments

@vetss
Copy link
Contributor

vetss commented Jun 2, 2016

We need to implement anyTimeSubscriptionInterrogation MAP operation.

@vetss vetss added this to the 7.1.0 milestone Jun 2, 2016
@vetss
Copy link
Contributor Author

vetss commented Jun 2, 2016

Base implementation is added by:
eb97801
I also added a commit that fixes soem issues and code style
773bbaf

@vetss
Copy link
Contributor Author

vetss commented Jun 2, 2016

We need to add some missed functionality / fix some bugs after adding of

  • MAPParameterFactory:
    • remove createAnyTimeSubscriptionInterrogationRequest, createAnyTimeSubscriptionInterrogationResponse (we do not add top level primitives there)
    • add of new added parameters: CAMELSubscriptionInfo, CallBarringData, CallForwardingData, CallHoldData, CallWaitingData, ClipData, ClirData, EctData, ExtCwFeature, MSISDNBS, ODBInfo, RequestedSubscriptionInfo
  • toString(): "ArrayList" parameters must display each element in the ArrayList. Whole ArrayList.toString brings no good data. So the code must look like. An example pf how to implement it is: org.mobicents.protocols.ss7.map.service.lsm.ReportingPLMNListImpl - parameter plmnList.
    Needed parameters to update:
    • CAMELSubscriptionInfoImpl: oBcsmCamelTDPCriteriaList, tBcsmCamelTdpCriteriaList, vtBcsmCamelTdpCriteriaList, mtSmsCamelTdpCriteriaList, oImBcsmCamelTdpCriteriaList, vtImBcsmCamelTdpCriteriaList
    • CallBarringDataImpl:callBarringFeatureList
    • CallForwardingData: forwardingFeatureList
    • CallWaitingData: cwFeatureList
    • MSISDNBS: basicServiceList
    • AnyTimeSubscriptionInterrogationResponse: msisdnBsList, csgSubscriptionDataList
  • missed unit tests:
    • CAMELSubscriptionInfo, CallBarringData, CallForwardingData, CallHoldData, CallWaitingData, ClipData, ClirData, EctData, ExtCwFeature, MSISDNBS, ODBInfo, RequestedSubscriptionInfo
  • missed MAPFunctionalTest

@vetss vetss mentioned this issue Jun 2, 2016
@vetss
Copy link
Contributor Author

vetss commented Jun 2, 2016

We need also update MAP RA for it:
RestComm/jain-slee.ss7#8

vgsub pushed a commit to vgsub/jss7 that referenced this issue Jun 6, 2016
vgsub pushed a commit to vgsub/jss7 that referenced this issue Jun 7, 2016
@vgsub vgsub mentioned this issue Jun 7, 2016
vetss pushed a commit to vetss/jss7 that referenced this issue Jun 9, 2016
vetss pushed a commit to vetss/jss7 that referenced this issue Jun 9, 2016
@vetss
Copy link
Contributor Author

vetss commented Jun 9, 2016

I have committed your update with little fixes into netty-2 branch from #112. Thanks for your work.

This is a list what is still missed:

  1. no unit test provides:
  • AnyTimeSubscriptionInterrogationRequestImpl,
  • AnyTimeSubscriptionInterrogationResponseImpl,
  • ExtCwFeature
  1. need the second unit test that will cover parameters that are missed (null) in the existing unit test
    (in the second unit test you can leave already tested field empty/null that are optional). This is important to me sure that no primitive encoding / decoding were tested and no errors
  • CAMELSubscriptionInfo,
  • CallBarringDataImpl,
  • CallForwardingData,
  • CallWaitingData,
  • ClirDataTest,
  • RequestedSubscriptionInfo,
  • ODBInfo,
  • MSISDNBS

@vetss vetss closed this as completed Jun 9, 2016
@vetss vetss reopened this Jun 9, 2016
vgsub pushed a commit to vgsub/jss7 that referenced this issue Jun 23, 2016
vetss pushed a commit to vetss/jss7 that referenced this issue Jun 27, 2016
@vetss
Copy link
Contributor Author

vetss commented Jun 27, 2016

Hello @vgsub

I have committed your update with some extra fixes.
52a11b5
03d9d3b

Thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants