New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong length check in UserDataHeaderImpl.java #275
Comments
Hello @smarek thanks for your feedback. Your note is correct. May I ask you to read THE TELESTAX OPEN SOURCE PLAYBOOK: |
I signed CLA, not with github, but with corporate e-mail account, but https://github.com/smarek is listed as my profile, so you should be able to match me against list of signatures. |
@smarek thanks for contributing this! 👍 I've already added your name in our Contributors Hall of Fame 👏 . If you would like to open a PR so that we can merge this in properly, we'd also be happy to do that too. Just let me know ;) |
@gsaslis thanks, this one is already fixed by mentioned commit, so i'll directly provide PR next time we find out something to fix. Cheers! |
awesome! (fwiw - i was just talking about you submitting a brand new PR with the same fix, so we can ensure the commit bears your name in GitHub. Probably just a minor detail now, but thought I'd check anyway ;) ) Looking forward to your future PRs ! |
Check in getApplicationPortAddressing16BitAddress() method of UserDataHeaderImpl is wrong, 16bit application port by docs ETSI TS 100 901 V7.5.0 (2001-12) section 9.2.3.24.4 is 4 octets (2 for destination and 2 for originator port)
In parser implementation this check is actually implemented correctly (see ApplicationPortAddressing16BitAddressImpl.java#L53 ), and these kind of checks might be eliminated from UserDataHeaderImpl.java if correct input to parser is checked on field-level.
Below proposed trivial fix diff against current master at 91be33c
The text was updated successfully, but these errors were encountered: