New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wrapper over some more parts of API #2

Merged
merged 21 commits into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@barnwal-paras
Contributor

barnwal-paras commented Jun 5, 2017

No description provided.

@gvagenas

This comment has been minimized.

Contributor

gvagenas commented Jun 5, 2017

@barnwal-paras lets work on one PR for now. Keep your work on one branch, unless if you have to experiment on something, and keep only one PR open.

Please update the branches as needed, and close one of the two PRs.

Thanks
George

@gvagenas

@barnwal-paras nice that you separated the unit tests from the actual implementation.

following some comments for the next steps:

  • Please add to gitignore the binaries and objects
  • Make Examples part of the solution, so if one open Restcomm.sln should have Examples also
  • Change the solution name to Restcomm-Connect-DotNet-SDK or something similar that will be clear this is the dotnet sdk
  • Make the solution a nuget so a developer can include it in his project
  • Change the namespace to something that will be clear this is the dotnet sdk, such as org.restcomm.connect.sdk.dotnet
  • Use the json endpoints
  • Base URL must be passed as an argument to the main constructor of the SDK and NOT be hardcoded

The most important of all is the Unit Test should work with a mock of Restcomm-Connect and NOT using the cloud.restcomm.com. Ping me if you need help on that but its very important that you don't test against cloud.restcomm.com

I guess you are working on the following:

  • Tutorial
  • Documentation
public accountProperties Properties;
public static string baseurl="https://cloud.restcomm.com/restcomm/2012-04-24/";

This comment has been minimized.

@gvagenas

gvagenas Jun 8, 2017

Contributor

@barnwal-paras base url should be configurable. The SDK will be used either with cloud.restcomm.com or any other Restcomm-Connect installation

namespace RestComm

This comment has been minimized.

@gvagenas

gvagenas Jun 8, 2017

Contributor

@barnwal-paras what is the convention for namespace? Can we use org.restcomm.connect.sdk.dotnet ?

{
RestClient client = new RestClient(baseurl+"Accounts/"+sid);

This comment has been minimized.

@gvagenas

gvagenas Jun 8, 2017

Contributor

@barnwal-paras we should use the JSON endpoints all over the project

barnwal-paras added some commits Jun 20, 2017

@gvagenas

This comment has been minimized.

Contributor

gvagenas commented Jun 22, 2017

@barnwal-paras there must be a problem with the solution setup. When I open Restcomm.sln the classes in the src folder doesn't exist.
screen shot 2017-06-22 at 14 39 47

Am I missing something? Can you please check?

Also please open issues for the missing items/tasks. Like this we merge this initial PR and your work from now on will be with PRs based on issues.

@gvagenas

This comment has been minimized.

Contributor

gvagenas commented Jun 22, 2017

Also provide README.md with the following:

  • Give a short description of the project (1-2 lines)
  • how to build the project
  • how to run the tests
  • dotnet version supported
  • Reference any dependencies that might be needed to be added by a developer
  • Provide instructions for where to download Restcomm and point to the restcomm documentation site
  • Provide information how and where developers can open issues and feature requests

Also please provide example application and instructions for how to run it etc.

Imagine you have a dotnet developer but not familiar with Restcomm-Connect, that wants to use the library. Given that, we must provide any necessary information for him to get started.

@barnwal-paras

This comment has been minimized.

Contributor

barnwal-paras commented Jun 22, 2017

I am working on documentation and description . Will update that on github by tomorrow .
Can you confirm if you have latest version of the project ( https://github.com/barnwal-paras/restcomm-sdk-dotnet.git ) from branch1 .Project in master branch is not updated .

@barnwal-paras

This comment has been minimized.

Contributor

barnwal-paras commented Jun 22, 2017

My bad . Actually i forgot to delete duplicate project file restcomm.csproj .please open solution file (Restcomm-dot-net-sdk.sln) or open Restcomm-dot-net-sdk.csproj inside Restcomm-dot-net-sdk folder to load the solution .

@gvagenas

This comment has been minimized.

Contributor

gvagenas commented Jun 23, 2017

Ok great, checking now @barnwal-paras

@gvagenas gvagenas merged commit 4e45a7d into RestComm:master Jun 23, 2017

@gvagenas

This comment has been minimized.

Contributor

gvagenas commented Jun 23, 2017

Great work @barnwal-paras 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment