Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make hardcoded links to restcomm configurable #137

Closed
otsakir opened this issue May 8, 2017 · 0 comments
Closed

Make hardcoded links to restcomm configurable #137

otsakir opened this issue May 8, 2017 · 0 comments

Comments

@otsakir
Copy link
Contributor

otsakir commented May 8, 2017 •
edited

RVD UI contains a number of hardcoded links to restcomm when accessing the API. Most (probably all) of them are relative links that work under the assumption that restcomm run in the same server as RVD. That won't always be the case especially when RVD is run a a microservice.

We need to make these links configurable.

Also, see:

https://docs.google.com/document/d/14aFvU7fhUaGeOwNo8hJ9bAIU5lpDoerqPRdrGRqJVs0/edit
otsakir added a commit that referenced this issue May 11, 2017
@otsakir
Added fixed parameter restcommBaseUrl to UI
e0bfd4e 
Refers #137
otsakir added a commit that referenced this issue May 25, 2017
@otsakir
Reviewed configurable links to restcomm/RVD
c3aac86 
Refers #137, #154
@otsakir otsakir closed this as completed May 31, 2017
@otsakir otsakir modified the milestone: Milestone 4 May 31, 2017
otsakir added a commit that referenced this issue Jun 12, 2017
@otsakir
Merged rvd_microservice work inside master
af479bc 
Squashed commit of the following:

commit 0b9e9896ad42675e596376ee9acb6fe0421b8e25
Merge: 2eae7aa 3052552
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Fri Jun 9 15:39:46 2017 +0300

    Merge branch 'issue146_rvd_microservice' into merge_rvd_microservice

commit 3052552
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Thu Jun 8 16:51:51 2017 +0300

    Added automated tests for CORS filtering

    Fixes #145

commit 1382fb5
Merge: 3dba4c5 2d7c536
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Wed Jun 7 14:27:33 2017 +0300

    Merge branch 'master' into issue146_rvd_microservice

commit 3dba4c5
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Wed Jun 7 11:21:21 2017 +0300

    Configuration finetuning so that by default allow all cors request

    Refers #145

commit 4a534b6
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Wed Jun 7 11:05:39 2017 +0300

    Added configurable cors-whitelist origin

    Refers #145

commit b1b1297
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Wed Jun 7 09:24:28 2017 +0300

    Added custom rvd.xml parser since xstream is not the proper tool for that

    Refers #145

commit 8969d44
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Tue May 30 16:51:44 2017 +0300

    Fork all logging to rvd.log to console too

    Refers #146

commit 344a24f
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Tue May 30 13:43:00 2017 +0300

    Fixes bug in contextPath of RvdConfiguration

    Refers #156

commit 708e8ab
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Tue May 30 12:13:36 2017 +0300

    Smarter logic when building controller URL

    It takes into account ContextPath instead of the hardcoded value '/restcomm-rvd'

    Refers #154

commit 5c9b1d5
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Tue May 30 09:50:02 2017 +0300

    Replaced hardcoded '/restcomm-rvd' with value from ServletContext and added to RvdConfiguration

    Refers #156

commit c3aac86
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Thu May 25 17:49:19 2017 +0300

    Reviewed configurable links to restcomm/RVD

    Refers #137, #154

commit d6aeddc
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Mon May 22 02:13:33 2017 +0300

    Use absolute urls in application registration based on configuration

    Added 'baseUrl' and 'useAbsoluteApplicationUrl' config params

    Refers #154

commit 04fc461
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Sun May 21 14:14:26 2017 +0300

    Use  restcommBaseUrl value from rvd.xml in client

    Refers #138

commit 18ce9c4
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Sun May 21 13:40:52 2017 +0300

    Wrapped ServletContext.getRealPath() inside utility method for cross-jboss compatibility

    Fixes listBundleWavs issue on wildfly 10

    Refers #138

commit d2b8fd1
Merge: 84dfc1a 240a38f
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Fri May 19 15:01:45 2017 +0300

    Merge branch 'master' into issue138_sandbox

commit 84dfc1a
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Thu May 11 12:53:18 2017 +0300

    WIP on #138 wehile evaluating running RVD/Restcomm under different domain names

commit e0bfd4e
Merge: 4befdbb 6560310
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Thu May 11 11:04:49 2017 +0300

    Added fixed parameter restcommBaseUrl to UI

    Refers #137

commit 6560310
Author: Orestis Tsakiridis <orestis.tsakiridis@telestax.com>
Date:   Wed May 3 11:31:16 2017 +0300

    Quick patches to test RVD in standalone mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@otsakir