Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1757 non restkit http #1759

Closed
wants to merge 5 commits into from
Closed

1757 non restkit http #1759

wants to merge 5 commits into from

Conversation

jedlau
Copy link

@jedlau jedlau commented Jan 21, 2014

Addresses #1757. (Sorry about the accidental merge commits.)

I wanted to add a test for this, which leveraged the fact that the RKOperationStartDate is set on the RKHTTPRequestOperation if the notification is actually run. (I would have checked to ensure that RKOperationStartDate is NOT set on a plain-vanilla AFHTTPRequestOperation.) However, the RKOperationStartDate is just a pointer value (not a constant), which I can't check for deterministically. Thoughts?

Thanks!

@blakewatters
Copy link
Member

I am not sure that this change is desirable for all users. I exclusively use RestKit’s logging for all of my object and HTTP level API interactions. Maybe a configuration switch is in order

@jedlau
Copy link
Author

jedlau commented Jan 21, 2014

Indeed, I got to this because I was seeing these RestKit logs even though I had RestKit logging disabled in my AppDelegate (I only un-comment the lines below as I need them):

    // RestKit debugging
    // RKLogConfigureByName("RestKit", RKLogLevelTrace);
    // RKLogConfigureByName("RestKit/CoreData", RKLogLevelTrace);
    // RKLogConfigureByName("RestKit/Network", RKLogLevelTrace);
    // RKLogConfigureByName("RestKit/ObjectMapping", RKLogLevelTrace);

How should I disable these logs?

@segiddins
Copy link
Member

@jedlinlau I believe some logging is enabled by default. Have you tried explicitly disabling logging (assuming you want it disabled)?

@jedlau
Copy link
Author

jedlau commented Jan 30, 2014

@segiddins , I can do that. Thanks.

@segiddins
Copy link
Member

@jedlinlau did that work? If so, please close the PR

@jedlau
Copy link
Author

jedlau commented Feb 18, 2014

Closing.

@jedlau jedlau closed this Feb 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants