Add currentOffset to RKPaginator #1280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Awesome. Will take a look at the test and advise. |
|
Thanks! I may also have to add something for the ios 5 proxies. When you get a chance, please let me know what else needs to be done so we can merge this. |
|
Made a few modifications to your PR. Merged to development in 2f11970 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in currentOffset to allow for a limit and offset paging model.
Also added a few tests too.
One test I added is failing: testThatURLReturnedReflectsStateOfPaginatorWithOffset
Seems to be related to the the Mock. Maybe you can help me figure out why, I don't have much experience with OCMOCK.