Report errors from obtainPermanentObjectIDsForInsertedObjects #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blakewatters any reason not to merge this? |
segiddins
added a commit
that referenced
this pull request
Jan 20, 2015
Report errors from obtainPermanentObjectIDsForInsertedObjects
|
Thanks @sixten :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
-[RKManagedObjectRequestOperation obtainPermanentObjectIDsForInsertedObjects:]calls-[NSManagedObjectContext obtainPermanentIDsForObjects:error:], but does not pass an error pointer. This means that when the attempt to obtain IDs fails, and the method returnsNO, it doesn't pass an error back up. That, in turn, means that the chain of completion blocks gets called withnilfor both arguments, which is ultimately, and incorrectly, interpreted as success.I have seen accounts of crashes when passing a non-
NULLpointer to this method, which may be why this code is this way now. If that's the case, and the real Core Data error can't be obtained and returned, this method should at least generate a new synthetic RestKit error in its failure case, so that everything else behaves properly.