RKRefetchManagedObjectInContext() can return object on incorrect context #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pr1001 could you make a PR for that? |
|
This seems to have failed on CI |
|
I'll look into this again. When I was developing I got ~180 test failures. I made a separate clean checkout of |
|
Make sure you're running the test server: |
If the function is passed a temporary managed object, it will return nil, instead of the original object not on the destination queue. Because -[RKRefetchingMappingResult refetchedMappingResult] would create a copy of the mapped results and overwrite their entries with the objects in the correct context, it also needed to be updated, since nil results wouldn't overwrite the original value.
context Also fix incorrect changes to the mutable dictionary.
pr1001
force-pushed
the
queue-crossing
branch
from
83ee56f
to
d0e1c0c
Compare
|
Sorry about not getting to this sooner. The request should now work and pass all tests. |
|
Looks ace! Will merge once CI runs |
|
Looks like it's good to good. |
segiddins
added a commit
that referenced
this pull request
Nov 16, 2015
RKRefetchManagedObjectInContext() can return object on incorrect context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RKRefetchManagedObjectInContext()function takes an object in an original context and refetches it on the provided destination context. However, if the object only has a temporary ID, the same object is returned. While it is true that refetching on the destination context would fail in the absence of a permanent ID, returning the original object can lead to it being used on the wrong, destination queue.While this function is only called inside of an
RKRefetchingMappingResult, which in turn only gets created byRKManagedObjectRequestOperationafter permanent IDs are obtained, I think it's dangerous to leave a potential context-crossing error in place and would be better to returnnil.