complete fix for include checks #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍🏻 |
segiddins
added a commit
that referenced
this pull request
Nov 17, 2015
complete fix for include checks
falkobuttler
pushed a commit
to JIFFinc/RestKit
that referenced
this pull request
May 13, 2016
* development: Update RKObjectManager.h Fix imports to be ready to use as dynamic framework Fix whitespace (tab width) Remove extra whitespace reintroduced by reverts RKHTTPRequestOperation: remove unused (and possibly dangerous) NSURLConnectionDelegate method. If it happens to be used it will try to trigger this method on a super - but no superclass implements it, so it will crash. RKMappingOperation: remove RestKit 'mappingOperationShouldSkipPropertyMapping:' deprecation warning by replacing with two corresponding methods (attribute, relationship mapping). Is it a suitable fix? added metadata list to RKTestMapping fixed RKObjectMapping equality (RestKit#2412) Revert "Merge pull request RestKit#2310 from RestKit/seg-bracket-imports" Revert "Merge pull request RestKit#2353 from TimothyChilvers/development" Revert "Merge pull request RestKit#2355 from dev4dev/development" Update ruby version to 2.3.0 [Pod] Update RKValueTransformers Update ruby version to 2.3.0 Fix bundle command Use a strong pointer inside the block. Completion block retained self, causing leaks if request operations did not complete or was not used at all. Removed the confusing comment "Weakly tag the HTTP operation with its parent object request operation". The HTTP operation is not tagged anymore and when it was it was not weak (in the end), which caused a major leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2352