Fixed a circular retain, causing non used request operations to leak #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 4, 2016 09:28
… parent object request operation". The HTTP operation is not tagged anymore and when it was it was not weak (in the end), which caused a major leak.
…id not complete or was not used at all.
rojo69
changed the title
segiddins
added a commit
that referenced
this pull request
Mar 7, 2016
Fixed a circular retain, causing non used request operations to leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed the confusing comment "Weakly tag the HTTP operation with its parent object request operation". The HTTP operation is not tagged anymore and when it was it was not weak (in the end), which caused a major leak.