Skip to content

Commit

Permalink
#6 Work on components refactor to depend on translate from 'react-i18…
Browse files Browse the repository at this point in the history
…n-polyglot' module and also remove old components
  • Loading branch information
jonatansalas committed Apr 22, 2017
1 parent 550a008 commit ab47c5c
Show file tree
Hide file tree
Showing 36 changed files with 54 additions and 125 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"react": "~15.4.0",
"react-dom": "~15.4.0",
"react-dropzone": "~3.6.0",
"react-i18n-polyglot": "^1.0.0",
"react-redux": "~4.4.5",
"react-router": "~2.8.1",
"react-router-redux": "~4.0.6",
Expand Down
2 changes: 1 addition & 1 deletion src/Admin.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import DefaultLayout from './mui/layout/Layout';
import Menu from './mui/layout/Menu';
import Login from './mui/auth/Login';
import Logout from './mui/auth/Logout';
import TranslationProvider from './i18n/TranslationProvider';
import { TranslationProvider } from './i18n';
import { AUTH_CHECK } from './auth';

const Admin = ({
Expand Down
32 changes: 2 additions & 30 deletions src/i18n/TranslationProvider.js
Original file line number Diff line number Diff line change
@@ -1,34 +1,6 @@
import { Children, PropTypes } from 'react';
import Polyglot from 'node-polyglot';
import { connect } from 'react-redux';
import { compose, withContext } from 'recompose';

import defaultMessages from './messages';

const withI18nContext = withContext({
translate: PropTypes.func.isRequired,
locale: PropTypes.string.isRequired,
}, ({ locale, messages = {} }) => {
const userMessages = messages[locale] || {};
const polyglot = new Polyglot({
locale,
phrases: { ...defaultMessages, ...userMessages },
});

return {
locale,
translate: polyglot.t.bind(polyglot),
};
});

const TranslationProvider = ({ children }) => Children.only(children);

TranslationProvider.propTypes = {
locale: PropTypes.string.isRequired,
messages: PropTypes.object,
children: PropTypes.element,
};
import { TranslationProvider } from 'react-i18n-polyglot';

const mapStateToProps = state => ({ locale: state.locale });

export default compose(connect(mapStateToProps), withI18nContext)(TranslationProvider);
export default connect(mapStateToProps)(TranslationProvider);
8 changes: 0 additions & 8 deletions src/i18n/TranslationUtils.js

This file was deleted.

21 changes: 0 additions & 21 deletions src/i18n/TranslationUtils.spec.js

This file was deleted.

4 changes: 2 additions & 2 deletions src/i18n/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export const DEFAULT_LOCALE = 'en';

export * from './TranslationUtils';
export * from 'react-i18n-polyglot/dist/lib/utils/TranslationUtils';

export englishMessages from './messages';
export translate from './translate';
export translate from 'react-i18n-polyglot/dist/lib/translate';
export TranslationProvider from './TranslationProvider';
15 changes: 0 additions & 15 deletions src/i18n/translate.js

This file was deleted.

14 changes: 0 additions & 14 deletions src/i18n/translate.spec.js

This file was deleted.

2 changes: 1 addition & 1 deletion src/mui/auth/Login.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { cyan500, pinkA200 } from 'material-ui/styles/colors';

import defaultTheme from '../defaultTheme';
import { AUTH_LOGIN } from '../../auth';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const styles = {
main: {
Expand Down
2 changes: 1 addition & 1 deletion src/mui/auth/Logout.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import compose from 'recompose/compose';
import MenuItem from 'material-ui/MenuItem';
import ExitIcon from 'material-ui/svg-icons/action/power-settings-new';

import translate from '../../i18n/translate';
import { translate } from '../../i18n';
import { AUTH_LOGOUT } from '../../auth';

class Logout extends Component {
Expand Down
2 changes: 1 addition & 1 deletion src/mui/button/CancelButton.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { Component, PropTypes } from 'react';
import { FlatButton, RaisedButton } from 'material-ui';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';
import { Link } from 'react-router';

class CancelButton extends Component {
Expand Down
2 changes: 1 addition & 1 deletion src/mui/button/CreateButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import FloatingActionButton from 'material-ui/FloatingActionButton';
import ContentAdd from 'material-ui/svg-icons/content/add';
import withWidth from 'material-ui/utils/withWidth';
import compose from 'recompose/compose';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const styles = {
floating: {
Expand Down
2 changes: 1 addition & 1 deletion src/mui/button/DeleteButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Link } from 'react-router';
import FlatButton from 'material-ui/FlatButton';
import ActionDelete from 'material-ui/svg-icons/action/delete';
import linkToRecord from '../../util/linkToRecord';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const DeleteButton = ({ basePath = '', label = 'aor.action.delete', record = {}, translate }) => <FlatButton
secondary
Expand Down
2 changes: 1 addition & 1 deletion src/mui/button/EditButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import compose from 'recompose/compose';
import FlatButton from 'material-ui/FlatButton';
import ContentCreate from 'material-ui/svg-icons/content/create';
import linkToRecord from '../../util/linkToRecord';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const EditButton = ({ basePath = '', label = 'aor.action.edit', record = {}, translate }) => <FlatButton
primary
Expand Down
2 changes: 1 addition & 1 deletion src/mui/button/ListButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { PropTypes } from 'react';
import { Link } from 'react-router';
import FlatButton from 'material-ui/FlatButton';
import ActionList from 'material-ui/svg-icons/action/list';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const ListButton = ({ basePath = '', label = 'aor.action.list', translate }) => <FlatButton
primary
Expand Down
2 changes: 1 addition & 1 deletion src/mui/button/RefreshButton.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { PropTypes } from 'react';
import FlatButton from 'material-ui/FlatButton';
import NavigationRefresh from 'material-ui/svg-icons/navigation/refresh';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const RefreshButton = ({ label = 'aor.action.refresh', translate, refresh }) => <FlatButton
primary
Expand Down
4 changes: 1 addition & 3 deletions src/mui/button/SaveButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ import React, { Component, PropTypes } from 'react';
import { connect } from 'react-redux';
import RaisedButton from 'material-ui/RaisedButton';
import FlatButton from 'material-ui/FlatButton';
import ContentSave from 'material-ui/svg-icons/content/save';
import CircularProgress from 'material-ui/CircularProgress';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

class SaveButton extends Component {

Expand Down
2 changes: 1 addition & 1 deletion src/mui/button/ShowButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import compose from 'recompose/compose';
import FlatButton from 'material-ui/FlatButton';
import ImageEye from 'material-ui/svg-icons/image/remove-red-eye';
import linkToRecord from '../../util/linkToRecord';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const ShowButton = ({ basePath = '', label = 'aor.action.show', record = {}, translate }) => <FlatButton
primary
Expand Down
2 changes: 1 addition & 1 deletion src/mui/delete/Delete.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import ViewTitle from '../layout/ViewTitle';
import Title from '../layout/Title';
import { ListButton } from '../button';
import { crudGetOne as crudGetOneAction, crudDelete as crudDeleteAction } from '../../actions/dataActions';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const styles = {
actions: { zIndex: 2, display: 'inline-block', float: 'right' },
Expand Down
2 changes: 1 addition & 1 deletion src/mui/detail/Create.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import ViewTitle from '../layout/ViewTitle';
import Title from '../layout/Title';
import { crudCreate as crudCreateAction } from '../../actions/dataActions';
import DefaultActions from './CreateActions';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

class Create extends Component {
getBasePath() {
Expand Down
2 changes: 1 addition & 1 deletion src/mui/detail/Edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import ViewTitle from '../layout/ViewTitle';
import Title from '../layout/Title';
import { crudGetOne as crudGetOneAction, crudUpdate as crudUpdateAction } from '../../actions/dataActions';
import DefaultActions from './EditActions';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

/**
* Turns a children data structure (either single child or array of children) into an array.
Expand Down
3 changes: 1 addition & 2 deletions src/mui/detail/Show.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@ import compose from 'recompose/compose';
import inflection from 'inflection';
import ViewTitle from '../layout/ViewTitle';
import Title from '../layout/Title';
import { DeleteButton, EditButton, ListButton } from '../button';
import { crudGetOne as crudGetOneAction } from '../../actions/dataActions';
import DefaultActions from './ShowActions';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

/**
* Turns a children data structure (either single child or array of children) into an array.
Expand Down
2 changes: 1 addition & 1 deletion src/mui/form/TabbedForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { Tabs, Tab } from 'material-ui/Tabs';
import { getFieldConstraints, getErrorsForForm, getErrorsForFieldConstraints } from '../../util/validate';
import Toolbar from './Toolbar';
import getDefaultValues from '../form/getDefaultValues';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

/**
* Validator function for redux-form
Expand Down
2 changes: 1 addition & 1 deletion src/mui/input/ImageInput.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { Component, PropTypes } from 'react';
import Dropzone from 'react-dropzone';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const defaultStyle = {
dropZone: {
Expand Down
2 changes: 1 addition & 1 deletion src/mui/input/NullableBooleanInput.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { PropTypes } from 'react';
import SelectInput from './SelectInput';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

export const NullableBooleanInput = ({ input, meta: { touched, error }, label, source, elStyle, resource, translate }) => (
<SelectInput
Expand Down
2 changes: 1 addition & 1 deletion src/mui/layout/DashboardMenuItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { PropTypes } from 'react';
import MenuItem from 'material-ui/MenuItem';
import DashboardIcon from 'material-ui/svg-icons/action/dashboard';
import { Link } from 'react-router';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const DashboardMenuItem = ({ onTouchTap, translate }) => (
<MenuItem
Expand Down
2 changes: 1 addition & 1 deletion src/mui/layout/Menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Link } from 'react-router';
import pure from 'recompose/pure';
import compose from 'recompose/compose';
import DashboardMenuItem from './DashboardMenuItem';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const styles = {
main: {
Expand Down
4 changes: 2 additions & 2 deletions src/mui/layout/Notification.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import React, { PropTypes } from 'react';
import { connect } from 'react-redux';
import Snackbar from 'material-ui/Snackbar';
import { hideNotification as hideNotificationAction } from '../../actions/notificationActions' ;
import translate from '../../i18n/translate';
import { hideNotification as hideNotificationAction } from '../../actions/notificationActions';
import { translate } from '../../i18n';

function getStyles(context) {
if (!context) return { primary1Color: '#00bcd4', accent1Color: '#ff4081' };
Expand Down
2 changes: 1 addition & 1 deletion src/mui/layout/Title.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { PropTypes } from 'react';
import onlyUpdateForKeys from 'recompose/onlyUpdateForKeys';
import compose from 'recompose/compose';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const Title = ({ defaultTitle, record, title, translate }) => {
if (!title) {
Expand Down
2 changes: 1 addition & 1 deletion src/mui/list/FilterButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Menu from 'material-ui/Menu';
import MenuItem from 'material-ui/MenuItem';
import ContentFilter from 'material-ui/svg-icons/content/filter-list';
import FieldTitle from '../../util/FieldTitle';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

export class FilterButton extends Component {
constructor(props) {
Expand Down
2 changes: 1 addition & 1 deletion src/mui/list/FilterForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import IconButton from 'material-ui/IconButton';
import ActionHide from 'material-ui/svg-icons/action/highlight-off';
import compose from 'recompose/compose';

import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const styles = {
card: { marginTop: '-14px', paddingTop: 0, display: 'flex', justifyContent: 'flex-end', alignItems: 'flex-end', flexWrap: 'wrap' },
Expand Down
2 changes: 1 addition & 1 deletion src/mui/list/FilterForm.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { createStore } from 'redux';
import { Provider } from 'react-redux';
import getMuiTheme from 'material-ui/styles/getMuiTheme';
import MuiThemeProvider from 'material-ui/styles/MuiThemeProvider';
import TranslationProvider from '../../i18n/TranslationProvider';
import { TranslationProvider } from '../../i18n';
import FilterForm from './FilterForm';
import TextInput from '../input/TextInput';

Expand Down
2 changes: 1 addition & 1 deletion src/mui/list/List.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import DefaultPagination from './Pagination';
import DefaultActions from './Actions';
import { crudGetList as crudGetListAction } from '../../actions/dataActions';
import { changeListParams as changeListParamsAction } from '../../actions/listActions';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const filterFormName = 'filterForm';

Expand Down
4 changes: 2 additions & 2 deletions src/mui/list/Pagination.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import IconButton from 'material-ui/IconButton';
import ChevronLeft from 'material-ui/svg-icons/navigation/chevron-left';
import ChevronRight from 'material-ui/svg-icons/navigation/chevron-right';
import { Toolbar, ToolbarGroup } from 'material-ui/Toolbar';
import { cyan500 } from 'material-ui/styles/colors'
import { cyan500 } from 'material-ui/styles/colors';
import compose from 'recompose/compose';
import withWidth from 'material-ui/utils/withWidth';
import translate from '../../i18n/translate';
import { translate } from '../../i18n';

const styles = {
button: {
Expand Down
2 changes: 1 addition & 1 deletion src/util/FieldTitle.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import inflection from 'inflection';
import pure from 'recompose/pure';
import compose from 'recompose/compose';

import translate from '../i18n/translate';
import { translate } from '../i18n';

const FieldTitle = ({ resource, source, label, translate }) => (
<span>
Expand Down
Loading

0 comments on commit ab47c5c

Please sign in to comment.