Remove Context::attach in favor of implementing Clone
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `attach` simpler.
This way, it is easier to see that we are spawning 4 actors.
The implementation is so simple, people can just clone the context themselves and call `run`. This shrinks the public API of xtra.
These extra visibility modifiers are not needed.
This is only used internally and using it requires careful evaluation of invariants as another instance of the receiver is handling the same broadcast mailbox.
This allows us to use `.clone` everywhere and remove the `cloned_new_broadcast_mailbox` function.
Some people may look for keywords like "multiple actors" instead of "message stealing".
thomaseizinger
force-pushed
the
remove-attach-context
branch
from
736eb01
to
afebdfc
Compare
Restioson
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95.