-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm-bindgen runtime #12
Conversation
Hey, thanks for the PR! Indeed, I definitely do want to support as many runtimes as possible to make xtra easy to use. I assume when you say "methods depending on time, like Otherwise, this PR looks good, and I am happy to merge :) It will probably be released alongside other additions such as compiling on stable and |
That's super cool! Also looking forward to the WASM support in smol.
Yeah, sorry, that's what I meant. Just added support for Looking forward to the 0.3 release - stable rust support is awesome :) |
Wow, that sounds cool!
Okay, cool :) I will merge now then. |
I've edited some stuff around |
Looks good to me, I'll let you know if I encounter an issue. I'm curious, why did you disable default-features for wasm-bindgen but not for the other runtimes? |
Different reasons:
|
Thanks for xtra! Exactly what I was looking for.
The README states that xtra is runtime agnostic, but I couldn't find an easy way to use it in WASM without the tokio or async-std runtime feature, hence I added the wasm-bindgen support. Hope this is useful.
To run the example
cargo install wasm-pack
is required.What's missing in this PR are the methods depending on time, like
notify_later
, but I'd be fine to file that as follow-up if the wasm-bindgen feature generally is something you want to support.