Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Feature: Request Delegates #32

Closed
rahul0x24 opened this issue Feb 4, 2018 · 3 comments
Closed

Feature: Request Delegates #32

rahul0x24 opened this issue Feb 4, 2018 · 3 comments
Labels
feature help wanted
Projects
Restofire 3.1

Comments

@rahul0x24
Copy link
Member

rahul0x24 commented Feb 4, 2018 •
edited

Request Delegates inspired by @codeOfRobin talk about http://khanlou.com/2017/01/request-behaviors/ at Swift Delhi Meetup
It will require refactoring Request, Upload and Download Operations to reuse the code.
@rahul0x24 rahul0x24 changed the title Refactor: Request Operations Feature: Request Delegates Feb 4, 2018
@codeOfRobin
Copy link

Oooh!

@codeOfRobin
Copy link

This sees like a good idea! Doesn't solve things like Linux compatibility (cos Alamofire doesn't work on Linux quite yet) but is otherwise really cool 👍

@rahul0x24 rahul0x24 mentioned this issue Feb 5, 2018
Closed
@rahul0x24 rahul0x24 added this to To do in Restofire 3.1 Feb 5, 2018
@rahul0x24 rahul0x24 moved this from To do to In progress in Restofire 3.1 Feb 5, 2018
@rahul0x24 rahul0x24 mentioned this issue Feb 5, 2018
Merged
rahul0x24 added a commit that referenced this issue Feb 5, 2018
@rahul0x24
feat: Request Delegates #32 (#39)
8998bc9 
* Add Request Delegates
* Add Tests
* Remove redundant conformance of protocol property
* Refactor Request Delegates
* Fix Tests
* Add Prepare Request Tests
* Update documentation
@rahul0x24 rahul0x24 moved this from In progress to Done in Restofire 3.1 Feb 5, 2018
@rahul0x24
Copy link
Member Author

Yes sad but @Alamofire has it in its scope for 5.0. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature help wanted
Projects
No open projects
Restofire 3.1
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rahul0x24 @codeOfRobin