Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint problems #173

Merged
merged 4 commits into from
Jun 28, 2019
Merged

Conversation

megatroom
Copy link
Contributor

Description

Current:

$ npm run lint
- 92636 problems (90734 errors, 1902 warnings)

Now:

$ npm run lint
+ 79 problems (64 errors, 15 warnings)

I didn't do any refactoring, I just adjusted the lint settings and fixed the formatting errors.

The remaining errors are logic errors, so I think it's best to stay as a technical debit for an upcoming refactoring.

How to test?

Run the lint and check the fixes.

Expected behavior

Since I haven't changed any behavior, it should continue to work the same way.

@hashtegner
Copy link
Member

hashtegner commented Jun 26, 2019

Is broken on react components, the cause appears to be file extensions (which is not jsx):
frontend/pages/login/title/title.js 4:3 error Parsing error: Unexpected token <

My suggestion is use only js

"rules": {
  "react/jsx-filename-extension": [1, { "extensions": [".js" }],
}

What do you think?

@megatroom
Copy link
Contributor Author

Is broken on react components, the cause appears to be file extensions (which is not jsx):
frontend/pages/login/title/title.js 4:3 error Parsing error: Unexpected token <

My suggestion is use only js

"rules": {
  "react/jsx-filename-extension": [1, { "extensions": [".js" }],
}

What do you think?

I think this is great! 🌟

I included this and other rules to support React. I also took the opportunity to add the new React Hooks rules for protection.

You will need run npm install again to test.

Copy link
Member

@hashtegner hashtegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤙

@hashtegner hashtegner merged commit d65fdad into ResultadosDigitais:master Jun 28, 2019
@megatroom megatroom deleted the hotfix/eslint branch June 28, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants