Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update cell #167

Merged
merged 2 commits into from
Dec 11, 2019
Merged

docs: update cell #167

merged 2 commits into from
Dec 11, 2019

Conversation

zero0Halo
Copy link
Contributor

@zero0Halo zero0Halo commented Dec 11, 2019 •
edited
Loading

Before submitting a pull request, please make sure the following is done:

I have done all of the following:

  • Added a top level class to all my components '.anchor-[COMPONENT NAME]'.
  • Used conventional commits for all work.
  • Tested my solution on Mobile & Tablet.
  • Wrote unit tests for states and all behavior (npm test) and passed coverage thresholds.
  • Updated snapshots for all permutations (npm test -- -u).
  • Accounted for hover, focus, blur, visited, & error states because they are not edge cases.
  • Created TODOs for known edge cases.
  • Documented all of my changes (inline & doc site).
  • Made sure that all accessibility errors are resolved.
  • Added stories with knobs for all possible configurations.
  • De-linted and ran prettier (npm run pretty) on my code.
  • Added name to OWNERS file for all new components
  • If adding a new component, add its export to the rollup config
  • package.json version is bumped (if necessary)

Outline your feature or bug-fix below

  • Cell
    • Adds the align and valign props to the api table
    • Adds notes that middle and center will be deprecated
    • Adds note that Cell is also exported as a submodule of Grid, and that the standalone will be deprecated
  • Updated doc site to use Cell's new valign and align props

Steve Swanson added 2 commits December 11, 2019 11:57
chore: updated anchor module to v1.3.4
b93456a 
chore: replaced all imports of Cell from Anchor with the Cell submodule from Grid

docs(Grid): added note about Cell submodule, added align and valign props to api
fix: removed usage of center and middle from all instances of Cell
5fb74c6
sharkparty
sharkparty reviewed Dec 11, 2019
View reviewed changes
docs/src/pages/components/grid.mdx
<Cell width={4}> I'm cell 3.</Cell>
<Cell width={6}> I'm cell 4.</Cell>
<Cell width={6}> I'm cell 5.</Cell>
<Grid.Cell width={4}> I'm cell 1.</Grid.Cell>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also be destructured at the top of the file to prevent this verbosity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variables can't be declared in the active code editor to my knowledge.

@zero0Halo zero0Halo marked this pull request as ready for review December 11, 2019 19:33
@zero0Halo zero0Halo merged commit 50b87d8 into master Dec 11, 2019
@zero0Halo zero0Halo deleted the docs/update-cell branch December 11, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkparty sharkparty sharkparty left review comments

@brandonlilly brandonlilly brandonlilly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zero0Halo @brandonlilly @sharkparty