Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: themeMerge properly merges keys with 0 or false as values #190

Merged
merged 2 commits into from
Feb 19, 2020
Merged

fix: themeMerge properly merges keys with 0 or false as values #190

merged 2 commits into from
Feb 19, 2020

Conversation

zero0Halo
Copy link
Contributor

@zero0Halo zero0Halo commented Feb 18, 2020 •
edited
Loading

Before submitting a pull request, please make sure the following is done:

I have done all of the following:

  • Added a top level class to all my components '.anchor-[COMPONENT NAME]'.
  • Used conventional commits for all work.
  • Tested my solution on Mobile & Tablet.
  • Wrote unit tests for states and all behavior (npm test) and passed coverage thresholds.
  • Updated snapshots for all permutations (npm test -- -u).
  • Accounted for hover, focus, blur, visited, & error states because they are not edge cases.
  • Created TODOs for known edge cases.
  • Documented all of my changes (inline & doc site).
  • Made sure that all accessibility errors are resolved.
  • Added stories with knobs for all possible configurations.
  • De-linted and ran prettier (npm run pretty) on my code.
  • Added name to OWNERS file for all new components
  • If adding a new component, add its export to the rollup config
  • package.json version is bumped (if necessary)

Outline your feature or bug-fix below

My code does...

@zero0Halo zero0Halo marked this pull request as ready for review February 18, 2020 23:41
sharkparty
sharkparty approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@sharkparty sharkparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zero0Halo zero0Halo merged commit 73360a1 into master Feb 19, 2020
@zero0Halo zero0Halo deleted the fix/theme-merge-0 branch February 19, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharkparty sharkparty sharkparty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zero0Halo @sharkparty