fix(Collapse): stop collapse icon from wrapping under button text #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done:
I have done all of the following:
'.anchor-[COMPONENT NAME]'
.npm test
) and passed coverage thresholds.npm test -- -u
).npm run pretty
) on my code.Outline your feature or bug-fix below
Because the floated button icon came after the button text, if the icon needed to wrap, it would wrap under the text. The solution is either to move the floated icon to be the first child of the button or to go with a flex-based approach. Making the parent button a flexbox allows the icon to come second, which is more intuitive, and the default
align-items: stretch
rule means that all of the vertical space beneath the icon will be reserved, so button text will never wrap under the icon. Additional tweaks were made to appearance and background-color, because in browsers other than Chrome a default "buttonFace" color (grey) was still showing through on this control.Some docs were also updated for clarity or formatting purposes.
An issue with
isOpen
was identified inCollapseGroup
with a TODO.