Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): support flip for cirulcar buttons #198

Closed
wants to merge 1 commit into from

Conversation

mintyfloss
Copy link
Contributor

@mintyfloss mintyfloss commented Apr 1, 2020

Before submitting a pull request, please make sure the following is done:

I have done all of the following:

  • Added a top level class to all my components '.anchor-[COMPONENT NAME]'.
  • Used conventional commits for all work.
  • Tested my solution on Mobile & Tablet.
  • Wrote unit tests for states and all behavior (npm test) and passed coverage thresholds.
  • Updated snapshots for all permutations (npm test -- -u).
  • Accounted for hover, focus, blur, visited, & error states because they are not edge cases.
  • Created TODOs for known edge cases.
  • Documented all of my changes (inline & doc site).
  • Made sure that all accessibility errors are resolved.
  • Added stories with knobs for all possible configurations.
  • De-linted and ran prettier (npm run pretty) on my code.
  • Added name to OWNERS file for all new components
  • If adding a new component, add its export to the rollup config
  • package.json version is bumped (if necessary)

Outline your feature or bug-fix below

My code does...

@mintyfloss
Copy link
Contributor Author

I have a snapshot to update, but I'm not able to push any changes :(

remote: error: GH006: Protected branch update failed for refs/heads/circular-flip.
remote: error: Required status check "continuous-integration/travis-ci" is expected. At least 1 approving review is required by reviewers with write access.
To github.com:RetailMeNot/anchor.git
 ! [remote rejected] circular-flip -> circular-flip (protected branch hook declined)
error: failed to push some refs to 'git@github.com:RetailMeNot/anchor.git'

${({ circular }) =>
circular
? css`
border-top-right-radius: 1000px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if base works below, then circular should work here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I didn't realize circular was in the theme. It looks like I have more work to do in this PR. Circular flip only works in the md size. The problem is that I want to make the flip be 50% of the button height and make it a square. I haven't thought of a good way to do that yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it a square on a circular button? do you have a mock?

height is something you can pass into the flip component from the button component, then just calc(${height} / 2) should work I think

@mintyfloss mintyfloss closed this May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants