feat(Button): add spacing props and remove sibling margin #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonlilly
commented
Apr 7, 2020
| ${({ block, margin }: StyledButtonProps) => | ||
| !margin && | ||
| css` | ||
| & + .anchor-button { |
There was a problem hiding this comment.
This was designed to automatically space buttons that are side by side. In practice I think it caused more surprise/frustration than it solved, and with space props added we can handle these cases easily/explicitly.
zero0Halo
reviewed
Apr 15, 2020
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@retailmenot/anchor", | |||
| "version": "1.5.8", | |||
| "version": "1.6.0", | |||
There was a problem hiding this comment.
Checking NPM, we actually only have released 1.5.7 so I think leaving it at 1.5.8 is probably fine.
There was a problem hiding this comment.
I bumped up to 1.6.0 because I consider it a "breaking" change. (i.e. Your buttons won't space properly if you were relying on that style)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done:
I have done all of the following:
'.anchor-[COMPONENT NAME]'.npm test) and passed coverage thresholds.npm test -- -u).npm run pretty) on my code.Outline your feature or bug-fix below
Adds spacing props to buttons and removes automatic sibling margins