fix: fixes a few misc. problems with AutoComplete and updates the docs #214
Conversation
zero0Halo
force-pushed
the
fix/autocomplete-fixes
branch
2 times, most recently
from
bd3d137
to
610da4b
Compare
zero0Halo
force-pushed
the
fix/autocomplete-fixes
branch
from
610da4b
to
9ceb29c
Compare
| label: string; | ||
| onMouseOver: (event?: React.MouseEvent) => void; | ||
| onSelect: (event?: React.FocusEvent) => void; | ||
| [key: string]: any; // Value also contains any new fields passed via the dataSource prop |
There was a problem hiding this comment.
Replacing new fields with something like additional custom fields makes more sense to me.
| value: { | ||
| active, | ||
| id, | ||
| isLink, // Here's the isLink key from the dataSource. All custom keys will be added to 'value'. |
There was a problem hiding this comment.
And I think this can simply be flagged as a custom field // custom field from datasource
| <ListItem active={index === currentIndex}>{label}</ListItem> | ||
| <ListItem active={active} key={key} onSelect={onSelect} onMouseOver={onMouseOver}> | ||
| <Typography weight={800} mr="2">{label}</Typography> | ||
| (active: {active.toString()}, currentIndex: {currentIndex}, id: {id}, key: {key} index: {index}) |
There was a problem hiding this comment.
Also I think it's interesting to see the extra info but not really helpful. And the font looks a little too bold.
There was a problem hiding this comment.
I agree the info isn't super useful, but I wanted to convey (as clearly as I could) that these are all of the properties available. I can definitely tone down the bold, it's a bit much.
| { label: 'I\'m a Link!', id: 'list-item-2', isLink: true, }, | ||
| { label: 'Another List Item', id: 'list-item-3', }, | ||
| { label: 'And Another', id: 'list-item-4', }, | ||
| { label: '...You Get The Idea', id: 'list-item-5', }, |
There was a problem hiding this comment.
The labels are a little confusing to me. At first it seemed to me like you were saying that only the first results was a Custom Results Template and the others were not. I think keeping these unbolded and listed as Item , Item 2, etc... like it was before seems better to me. 🤷
zero0Halo
force-pushed
the
fix/autocomplete-fixes
branch
from
9ceb29c
to
9919c75
Compare
…Focus prop fix(AutoComplete): custom result story now spreads value to attach events fix(AutoComplete): added size knob for StateBasedAutoCompleteStory fix(Input): line heights given to inputs to fix cutoff of text docs(autocomplete): better documentation on custom result templates fix(build): explicitly added csstypes module docs(autocomplete): changes made based on PR comments
zero0Halo
force-pushed
the
fix/autocomplete-fixes
branch
from
3adba29
to
3016423
Compare
fix(AutoComplete): isFocused now receives its initial value from autoFocus prop
fix(AutoComplete): custom result story now spreads value to attach events
fix(AutoComplete): added size knob for StateBasedAutoCompleteStory
fix(Input): line heights given to inputs to fix cutoff of text
docs(autocomplete): better documentation on custom result templates
Before submitting a pull request, please make sure the following is done:
I have done all of the following:
'.anchor-[COMPONENT NAME]'.npm test) and passed coverage thresholds.npm test -- -u).npm run pretty) on my code.Outline your feature or bug-fix below