Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable loading FDS files #32

Closed
wants to merge 2 commits into from
Closed

Enable loading FDS files #32

wants to merge 2 commits into from

Conversation

rzumer
Copy link
Contributor

@rzumer rzumer commented Aug 3, 2018

FDS files cannot use the same parsing strategy as regular NES files. This solves the problem by falling back onto the default loading strategy if NES header parsing fails.

@rzumer rzumer mentioned this pull request Aug 3, 2018
Closed
@rzumer rzumer requested a review from leiradel August 3, 2018 21:45
@rzumer rzumer changed the base branch from master to develop August 3, 2018 22:14
@rzumer
Copy link
Contributor Author

rzumer commented Aug 3, 2018

I will resubmit this PR from a bugfix branch based on develop (git flow model) with a few improvements.

@rzumer rzumer closed this Aug 3, 2018
@rzumer rzumer mentioned this pull request Aug 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiradel leiradel Awaiting requested review from leiradel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rzumer @leiradel