This repository has been archived by the owner on Sep 8, 2019. It is now read-only.
FECUI_HandleEmuCommands was not re-entrant [fixes RANes crash on load savestate] #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any of the function calls invoked from
FCEUI_HandleEmuCommands
resulted inFCEUI_HandlEmuCommands
being called again, the loop counteri
would be updated by the nested call toNUM_EMU_CMDS
, making the assignment at the end of the loop write past the end of the array. This results in memory corruption, and depending on what lied beyond the end of the array, could lead to crashing.I've made
i
a local variable so a recursive call won't muck with it. The external function usingi
was modified to look atexeccmd
instead.