Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure dev box #1176

Merged
merged 7 commits into from Oct 2, 2022
Merged

Restructure dev box #1176

merged 7 commits into from Oct 2, 2022

Conversation

luchaos
Copy link
Member

@luchaos luchaos commented Oct 2, 2022

Remove dedicated game rename page and integrate into game dev box.
Remove unused redirector comments.
Unify comments layout.

Remove dedicated game rename page.
Remove unused redirector comments.
Unify comments layout.
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like the changes. I've offered a few additional suggestions since we're already changing things.

public/gameInfo.php Outdated Show resolved Hide resolved
public/gameInfo.php Outdated Show resolved Hide resolved
public/gameInfo.php Outdated Show resolved Hide resolved
public/gameInfo.php Outdated Show resolved Hide resolved
public/gameInfo.php Outdated Show resolved Hide resolved
public/gameInfo.php Outdated Show resolved Hide resolved
public/gameInfo.php Show resolved Hide resolved
@luchaos
Copy link
Member Author

luchaos commented Oct 2, 2022

Now I wonder if the claims block should go back into the left column as well, reuniting it with the other management links.

Screenshot 2022-10-03 at 01 04 37

Maybe leaving the claim button in the right column? Actions vs. links.

This wasn't meant to be introduced before a general typography overhaul.
@luchaos
Copy link
Member Author

luchaos commented Oct 2, 2022

Reverted an unintended change where the line-height of buttons and form inputs was increased.

This wasn't meant to be introduced before a general typography overhaul.

(See updated screenshot above)

@Jamiras
Copy link
Member

Jamiras commented Oct 2, 2022

Maybe leaving the claim button in the right column? Actions vs. links.

I like that idea. Note that "Manage Leaderboards" becomes a button if there aren't any.

May even want to split them so "Manage Claims" is on the left (it's only visible to admins) and then move Claim History below the Claim/Drop button

@luchaos
Copy link
Member Author

luchaos commented Oct 2, 2022

May even want to split them so "Manage Claims" is on the left (it's only visible to admins) and then move Claim History below the Claim/Drop button

🙌

Screenshot 2022-10-03 at 01 50 48

Note that "Manage Leaderboards" becomes a button if there aren't any.

I'd say that's fine for now - something for another time? 😅

@luchaos luchaos merged commit 59961af into RetroAchievements:master Oct 2, 2022
@luchaos luchaos deleted the game-dev-box branch October 2, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants