parse MemAddr with RegEx and show a fancy table #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huge thanks to @stt for showing that it's possible to parse MemAddr with Regular Expressions 馃
|
@luchaos marked you as a reviewer because my PHP code looks a bit ugly 馃槄 |
|
Damn that looks nice. Way to go! |
|
in this last commit I've used
|
|
Your image is a little small @meleu but |
|
IIRC luchaos said that he would be busy this weekend, and since this PR is not changing anything on database stuff (it's just a presentation thing), I'm going to merge it and putting it alive. We can polish the code later on v2. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all: huge thanks to @stt for showing me that it's possible to parse MemAddr with Regular Expressions 馃
This PR changes the behavior of
GetAchievementPatchReadableHTML(), making it produce this output:rather than the current buggy one:
