-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(StaticData): use correct count of total games #2453
fix(StaticData): use correct count of total games #2453
Conversation
@@ -47,11 +48,13 @@ class EventServiceProvider extends ServiceProvider | |||
AchievementPublished::class => [ | |||
DispatchUpdateGameMetricsJob::class, // dispatches GameMetricsUpdated | |||
DispatchUpdateDeveloperContributionYieldJob::class, // dispatches UpdateDeveloperContributionYield | |||
UpdateTotalGamesCount::class, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually I see this also updating TotalAchievementsCount. Should that logic just be rolled into this class and renamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point -- personally I could go either way on this (having two separate actions vs a single action).
I lean more towards having two separate actions just because the queries to construct the two data points are likely quite different, but that's a very very loosely-held opinion.
Oh man, I can finally do my milestone announcements without having to explain the wrong stats every time 😆 |
Removes
static_addnewgame()
in favor of a scheduled command which updatesNumGames
to the correct value on a periodic basis.Resolves #1356.