Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1594: back behavior correction #1596

Closed
wants to merge 1 commit into from
Closed

fix #1594: back behavior correction #1596

wants to merge 1 commit into from

Conversation

rahul-gill
Copy link
Contributor

related: #1594

@rahul-gill rahul-gill closed this by deleting the head repository Jan 29, 2024
@ccyybn
Copy link

ccyybn commented Jun 15, 2024

why closed?

@rahul-gill
Copy link
Contributor Author

Because this project is dead and I've build a release with this fixes here

@ccyybn
Copy link

ccyybn commented Jun 15, 2024

I found a problem with this commit: rahul-gill@80fa84d. The artist images will never show in the release version app, but the debug version has no problem. 

image

before the commit

These artist images are from the covers embedded in the audio files

image

@ccyybn
Copy link

ccyybn commented Jun 16, 2024

rahul-gill@80fa84d

I found that the problem with the artist images not showing up was caused by R8 full mode, disabling it fixed the problem

android.enableR8.fullMode=false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants