Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --screenrotate #348

Merged
merged 3 commits into from Jan 20, 2018
Merged

Conversation

tomaz82
Copy link
Collaborator

@tomaz82 tomaz82 commented Jan 18, 2018

Basically does what display_rotate does in config.txt, except doing it for ES only, and without the penalty that comes with doing a 90 or 270 degree rotation using display_rotate. This also works for platforms that doesn't allow to have the OS or whatnot to do the rotation.

It maps the same as display_rotate
--screenrotate 0 == nothing
--screenrotate 1 == 90 degrees
--screenrotate 2 == 180 degrees
--screenrotate 3 == 270 degrees

Only tested with default Carbon theme which looks "ok" but obviously wrong in the case of 1 and 3, will need a theme made for a reversed aspect ratio ( 9/16 instead of 16/9 if using a 16/9 screen )

Thanks to @zanac who did the first part

@joolswills
Copy link
Member

Thanks for this - a feature that has been requested by quite a few people over the years.

@zanac
Copy link

zanac commented Jan 18, 2018

Thanks is very useful for Pandora that dont allow screen rotate by config.

@tomaz82
Copy link
Collaborator Author

tomaz82 commented Jan 18, 2018

Note, this is still being worked on, I forgot about the omxplayer which needs to be handled, among a few other bits and pieces, so will update this further tonight / tomorrow

@tomaz82
Copy link
Collaborator Author

tomaz82 commented Jan 19, 2018

I think I've covered all bases now, would be appreciated if someone ( or several someones ) tested this, but I think it's good to go.

@zanac
Copy link

zanac commented Jan 20, 2018

Cannot test omx (i test on pandora box porting for which i use this patch) and with libvlc work very well! Good work thanks!

@joolswills joolswills merged commit 5f062ff into RetroPie:master Jan 20, 2018
@tomaz82 tomaz82 deleted the rotateScreen branch January 22, 2018 19:58
@Shakz76
Copy link

Shakz76 commented Aug 28, 2018

@tomaz82
I had some questions come my way about this one....where is this setting made? Working on the ORA project and we have been running the latest version of emulationstation for a while. Was not aware of this feature. Is it a setting in es_settings.xml? Not sure where to put the var.

@tomaz82
Copy link
Collaborator Author

tomaz82 commented Aug 28, 2018

No, it's a commandline option for when ES is launched

@aarkay14
Copy link

Dear Team,

May I ask how to add this parameter so that ES starts in Rotated mode on RetroPie boot? Also does this affect RetroArch orientation as well? If Not how will I change the same?

-Rama

@ignusfast
Copy link

New to this whole thing - is this fix in the stable release?

@jackwebb714
Copy link

I have read through several threads regarding the use of this command line instruction. I located the autostart.sh and added a line that says --screenrotate 3. After reboot I get a message “command not found”. So this does not work for me. I have an Arcade1up Galaga machine I’ve modded per ETA Primes video and modified the config.txt by adding the line display_rotate=3. This works but is not ideal for reasons mentioned in other threads regarding unstable character shadows etc.
Any help regarding how to rotate the ES Display w/o modding the config.txt and HOW to do it, would be very much appreciated. Thanks in advance. Jack

@joolswills
Copy link
Member

Please use our forum. Note that 3rd party images are not supported.

@jackwebb714
Copy link

Fine. I am absolutely new to this type of social media. I have read thru the guides and see no where or way to post on "our forum". Would you care to provide a link? thanks.

@pjft
Copy link
Collaborator

pjft commented May 17, 2019

https://retropie.org.uk/forum/

But, as mentioned, third-party images are not supported. The link just shared is where you would have likely gotten the original RetroPie image for your setup.

Thanks.

@jackwebb714
Copy link

Oh I see. Your use of the word images is not a picture image, you mean retropie image. Understood. Therefore my question may not be supported. Well that's fine. However the root question is where to put the command line --screenrotate 3 that I read on GitHub "Add support for --screenrotate #348". I don't mean to be dense just trying to get to the right area to find out why I get an error when inserting that command line. Sorry, I just assumed since the support question originate here I could ask for clarification. My bad.

@ImArchimedes
Copy link

So, I’m a little late to the show but I can’t get —screenrotate to have any affect. Originally, I was trying this by modifying my autostart.sh. My auto start looked like this:

emulationstation --no-exit --screensize 1080 1920 --screenoffset 0 0
--screenrotate 3
#auto

No luck with any screen rotate number. Tried launching from a shell using screenrotate command and same issue. I know the other commands in my autostart are being used since no-exit is functioning. Any thoughts?

@jackwebb714
Copy link

Not at the moment, no. Apparently, as I just Googled and read, to get the edit to the autostart.sh file to work you have to; Quote “Install Emulationstation dev version from the Experimental section of RetroPie Setup”. I did install ES dev version from experimental section. However...I do not know how to run the ES dev version versus the default ES. Stuck here at the moment. Right now I am rotating the screen 90 deg through editing the config.txt file. But again, that is a less desirable method.
If I figure out how to run the ES dev I’ll let you know.

@pjft
Copy link
Collaborator

pjft commented May 21, 2019

When you install ES-dev it should automatically update autostart.sh to run the ES-dev build instead of the standard one.

Please use the forums for these threads - lots more people there, better odds of finding solutions, and the best place for this type of guidance to help others with the same problem in the future as well.

Thanks.

lubosz pushed a commit to lubosz/EmulationStation that referenced this pull request Feb 29, 2020
Wifi SSID enumeration/selection using "batocera-wifi" script
@Jousterpunk
Copy link

Is there a way to invoke this dynamically without a configuration change, or to pick a config on restart from the GUI? I have a manually rotated monitor, and I would like to run ES in either horizontal or vertical mode depending on which game collection I'm playing.

@cmitu
Copy link

cmitu commented Jul 11, 2020

@Jousterpunk Please use the forum for support questions.

Yaoh pushed a commit to Yaoh/EmulationStation that referenced this pull request Jul 13, 2020
NeilRickards added a commit to NeilRickards/EmulationStation that referenced this pull request Dec 13, 2020
Add to help screen the extra parameters from RetroPie#324 and RetroPie#348
NeilRickards added a commit to NeilRickards/EmulationStation that referenced this pull request Dec 13, 2020
Add to help screen the extra parameters from RetroPie#324 and RetroPie#348.
Also replace tabs with spaces for more consistent display, normalize capitalization of first letters, and MB is the correct abbreviation for MegaBytes.
@NeilRickards NeilRickards mentioned this pull request Dec 13, 2020
@tomhannen
Copy link

tomhannen commented Feb 9, 2023

The latest changelog for EmulationStation / RetroPie v4.8 says screen rotation has been enabled, but I can't see any explanation of how to configure it either in the current documentation or in the forums. Please could someone explain how to do this for a Raspberry Pi 4? Either here, or in the forums, in the changelog or the docs! Many thanks

See my forum request here: https://retropie.org.uk/forum/topic/33887/pi4-with-vertical-screen-orientation-newest-advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet