Add support for md_thumbnail & md_marquee

[supersquared]

• Added support for md_thumbnail in VideoGameListView
• Added support for md_thumbnail & md_marquee in DetailedGameListView

[joolswills]

Anyone have any issues with these changes?

[supersquared]

I don't know if I can answer since I am the person who made the changes, but I'm using it since almost one month and half without any issue (many games with and without md_thumbnail and md_marquee)

[pjft]

Read the code and have a question about the behavior for themes that don't specify the thumbnail - even if the gamelist.xml might have one for the games, as a result of scraping.

Other than that, no objections. Sorry for the delay.

[supersquared]

Just committed the changes to have thumbnail off the screen by default. is that ok ?

[supersquared]

@jrassa how do I squash the commits?

[jrassa]

@supersquared you need to do a rebase. Here is a pretty good tutorial. Let me know if you need any additional help.

[fabricecaruso]

You never call setVisible(true), so If you do it that way, theme designers will have to add true in the theme for the elements to be visible :

It should not be required
It's not required for other components. Why should it be diffent ?
If a theme designer adds a md_thumbnail element, it should be visible by default.

Maybe add something like that :

mThumbnail.setVisible(theme->getElement(getName(), "md_thumbnail", "image")); // <- THIS
mThumbnail.applyTheme(theme, getName(), "md_thumbnail", ALL ^ (PATH));

To squash 6 commits do that :
git rebase -i HEAD~6
keep the first item with "pick", replace the others with "s" ( or squash ) keyword & save.
then when complete, force push with
git push -f

[jrassa]

@fabricecaruso There shouldn't be a need to explicitly call setVisible(true). This is already handled in GuiComponent:
https://github.com/RetroPie/EmulationStation/blob/master/es-core/src/GuiComponent.cpp#L440

When applying any other theme properties, visible will be set to true unless explicitly set to false. This was tested and verified when visible was added.

[supersquared]

Squashed! @fabricecaruso @jrassa thank you for the help on squashing ;)

[fabricecaruso]

already handled in GuiComponent:

You're absolutely right, sorry. Everything's fine.