RPI support: split omxplayer build option #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the build options and source files to enable `omxplayer` for video previews only when the `OMX` option is used.
Updated the build instructions on RPI accordingly and added some notes about the deprecation of the BRCM GPU drivers in RasPI OS 'Bullseye'.
Previously, the `RPI` build option would be used to add both RPI specific audio settings/VRAM limits AND add `omxplayer` support. However, `omxplayer` does not work with the RPI KMS video driver (`vc4-kms-v3d`) or with a 64bit RPI system, due to the lack of OpenMAX (OMX) API support.
The new RasPi OS ('bullseye') has made the KMS driver the default [1] and doesn't offer `omxplayer` anymore (considered deprecated [2]).
Splitting the OMX support from the RPI option allows to set some default values for RPI systems without automatically adding the `omxplayer` bits.
[1] https://www.raspberrypi.com/news/raspberry-pi-os-debian-bullseye/
[2] popcornmix/omxplayer@1f1d0ccd65
cmitu
added a commit
to cmitu/RetroPie-Setup
that referenced
this pull request
May 14, 2022
Starting with RaspiOS 'bullseye', the `omxplayer` RPI video player is no longer supported. Use the new EmulationStation build option (`OMX`) to enable the `omxplayer` bits only for `dispmanx` platforms. The new options is added in RetroPie/EmulationStation#792. The `RPI` build option is used only for pre-setting some program settings on the Raspberry Pi platforms (audio/video memory).
|
Thanks. |
GeorgeMcMullen
pushed a commit
to GeorgeMcMullen/RetroPie-Setup
that referenced
this pull request
Sep 7, 2022
Starting with RaspiOS 'bullseye', the `omxplayer` RPI video player is no longer supported. Use the new EmulationStation build option (`OMX`) to enable the `omxplayer` bits only for `dispmanx` platforms. The new options is added in RetroPie/EmulationStation#792. The `RPI` build option is used only for pre-setting some program settings on the Raspberry Pi platforms (audio/video memory).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the build options and source files to enable
omxplayerfor video previews only when theOMXoption is used.Updated the build instructions on RPI accordingly and added some notes about the deprecation of the BRCM GPU drivers in RasPI OS 'Bullseye'.
Previously, the
RPIbuild option would be used to add both RPI specific audio settings/VRAM limits AND addomxplayersupport. However,omxplayerdoes not work with the RPI KMS video driver (vc4-kms-v3d) or with a 64bit RPI system, due to the lack of OpenMAX (OMX) API support.The new RasPi OS ('bullseye') has made the KMS driver the default [1] and doesn't offer
omxplayeranymore (considered deprecated [2]).Splitting the OMX support from the RPI option allows to set some default values for RPI systems without automatically adding the
omxplayerbits.[1] https://www.raspberrypi.com/news/raspberry-pi-os-debian-bullseye/
[2] popcornmix/omxplayer@1f1d0ccd65
For RetroPie, we'll have to adjust the build options accordingly for the package(s).