New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trivial Bug: Installer is not using shallow cloning for submodules #1743
Comments
This could be problematic actually - http://stackoverflow.com/questions/27188899/shallow-clone-with-submodules-in-git-how-to-use-pointed-commits-and-not-latest |
Hmm, I think that's right. I was going to actually try it after this had finished... It may not be possible. |
(I was using --depth since older git doesn't have --shallow-submodules) - im reverting. sorry. |
What are the chances of you guys accepting a pull request to NOT use shallow cloning and to use persistent directories for git checkouts? (I'm on IRC at the moment, if you want to talk about it there) |
Bearing in mind x86 is not the primary target for retropie (rpi with small sd cards are), it would have to be an optional feature etc. |
I added a quick variable - will work for most stuff, but there may be issues
|
variable name likely to change in the future and may be set automatically for desktop machines, but you can give it a test now anyway. |
While watching the installer run through, I noticed that most (all?) modules are shallow cloned.
Disregarding if that is a good idea or not (personally, I think it's a BAD idea, but that's not for this ticket), I noticed that you're not shallow cloning the SUBMODULES.
And it sits there.. This is because ffmpeg is a huge repository.
I would suggest you add
--shallow-submodules
to your git clone command, so only the required hash is retrieved.The text was updated successfully, but these errors were encountered: