Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scummvm-2.0.0 support #2227

Closed
dafioram opened this issue Dec 21, 2017 · 7 comments
Closed

Add scummvm-2.0.0 support #2227

dafioram opened this issue Dec 21, 2017 · 7 comments
Assignees

Comments

@dafioram
Copy link

Scummvm 2.0.0 is out.

Users can pull 2.0.0 from source and compile just fine with scummvm.sh
This can be accomplished by changing:
RetroPie-Setup/scriptmodules/emulator/scummvm.sh
line #30
-gitPullOrClone "$md_build" https://github.com/scummvm/scummvm.git "branch-1-9"
+gitPullOrClone "$md_build" https://github.com/scummvm/scummvm.git "branch-2-0-0"

2.0.0 was developed with sdl 2.0 in mind so I am not sure how well compiling from source for sdl1 will work (i.e., scummvm-sdl1.sh).

Currently, the raspberry pi binary for scummvm 2.0.0 on scummvm's website cannot not be downloaded and used on retropie (specifically a raspberry pi) because it was compiled with a higher png library version than raspian jessie has (it was compiled with libpng16 and jessie only has libpng12). So if a binary scummvm 2.0.0 is to be used on a raspberry pi running retropie then either:

  1. Retropie itself must compile libpng16 from source (maybe someone could upload an unofficial libpng16 binary for jessie).
  2. We wait till Retropie is running on raspian stretch (which has libpng16 standard).
  3. Someone compiles scummvm 2.0.0 on retropie 4.3 (jessie) by changing the line of code as shown above to pull from 2-0-0 instead of 1-9 and then upload this binary somewhere that other retropie users can grab. This method will compile scummvm 2.0.0 with libpng12 so it will work on other retropie's running 4.3.
@joolswills
Copy link
Member

Thanks - We are planning to update - we were just making sure everything works. The sdl1 module will be removed as it was added due to some joystick bugs in 1.9 with sdl2.

@joolswills joolswills self-assigned this Dec 28, 2017
@AnthraxLeprosyPi
Copy link

Hey guys,

Is there any update on this?
If I understand the above correctly I could just build from source and it would work on a raspberry pi 3?

Best regards
Anthrax

@Darknior
Copy link

Read before : f747616

Yes you can build from source the 2.0

@joolswills
Copy link
Member

the rpi binaries should be updated also. This issue is closed as it has been resolved.

@AnthraxLeprosyPi
Copy link

Ah, nice thx you guys!

@joolswills
Copy link
Member

joolswills commented Feb 19, 2018

NP. Please use the forum for any further questions.

@AnthraxLeprosyPi
Copy link

Worked like a charm.

Forums next time!

joolswills added a commit to joolswills/RetroPie-Setup that referenced this issue Apr 7, 2018
 * scummvm built against sdl2 now has fixed joypad support, so the scummvm-sdl1 is no longer needed. However it is being left for now, in case there are other isues.
pjft pushed a commit to pjft/RetroPie-Setup that referenced this issue Mar 5, 2019
 * scummvm built against sdl2 now has fixed joypad support, so the scummvm-sdl1 is no longer needed. However it is being left for now, in case there are other isues.
rodvieirasilva pushed a commit to rodvieirasilva/RetroPie-Setup that referenced this issue Mar 29, 2019
 * scummvm built against sdl2 now has fixed joypad support, so the scummvm-sdl1 is no longer needed. However it is being left for now, in case there are other isues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants