Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

giving to on[start|end] access to runcommand arguments #1610

Closed
wants to merge 1 commit into from
Closed

giving to on[start|end] access to runcommand arguments #1610

wants to merge 1 commit into from

Conversation

meleu
Copy link
Contributor

@meleu meleu commented Aug 4, 2016

There's some useful stuff to do if runcommand-on[start|end] have access to the ROM name (usually the 4th runcommand argument).

There's some useful stuff to do if runcommand-on[start|end] have access to the ROM name (usually the 4th runcommand argument).
@joolswills
Copy link
Member

Thanks - but prefer to pass in the actual info of what it is running including emulator choice (and link it in to #1358).

@joolswills joolswills closed this Aug 4, 2016
@meleu
Copy link
Contributor Author

meleu commented Aug 4, 2016

But it won't hurt anyone...
Is there a way to make on[start|end] get the ROM name?

@meleu
Copy link
Contributor Author

meleu commented Aug 4, 2016

caver01 gave some good reason to add this feature:
https://retropie.org.uk/forum/topic/2211/a-question-about-runcommand-sh/13

And I can think some others...

@joolswills
Copy link
Member

You are welcome to maintain your own version, but this adds functionality and I don't want to merge it in and then have to change it later - as users would then need to adjust their scripts. You don't get the emulator name in the parameters by doing the above.

To avoid working on stuff that won't be accepted you could discuss it with me first on the forum.

@joolswills
Copy link
Member

I didn't say I was against the idea - just the implementation.

@meleu
Copy link
Contributor Author

meleu commented Aug 4, 2016

I tagged you on the forum thread.
Thanks for the answer.

@joolswills
Copy link
Member

You did. 44 mins ago and I didn't have a chance to reply - I'm at work.

@meleu
Copy link
Contributor Author

meleu commented Aug 4, 2016

That "thanks" was about the answer here, at github! It is sincere. :-) I said I won't be kidding (neither ironic) anymore!
I'm at work too. Let's get back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants