Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated esthemes.sh with 1 new theme. #3099

Closed
wants to merge 2 commits into from
Closed

Updated esthemes.sh with 1 new theme. #3099

wants to merge 2 commits into from

Conversation

c64-dev
Copy link
Contributor

@c64-dev c64-dev commented Apr 10, 2020

Added the new Epic Noir theme from Chicuelo and nil06.

New Epic Noir theme.
@cmitu
Copy link
Contributor

cmitu commented Apr 10, 2020

@c64-dev thanks for submitting the theme.
A few modifications are needed for this to work automatically from RetroPie's theme installer

  • your repository should be named es-theme-epicnoir
  • the addition to the esthemes.sh file should contain just the short name of the theme
c64-dev epicnoir

@c64-dev
Copy link
Contributor Author

c64-dev commented Apr 14, 2020

@cmitu I resolved the conflict in esthemes.sh and renamed the repo as needed. Let me know if everything is in order.

@cmitu
Copy link
Contributor

cmitu commented Apr 14, 2020

@c64-dev unfortunately you merged the latest commits from master (added since your initial PR modifications) into your feature branch and this will bring up unnecessary commits. It would be easier to re-do the pull request with a fresh new branch (from current RetroPie-Setup master) and re-submit as a new PR.

@joolswills joolswills closed this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants