Joy2key improvements #3196
Joy2key improvements #3196
Conversation
* joy2key.py: fix decode error (that occurred whenever return value was anything other than bytes) * joy2key.py: remove usage of os.fork() that was preventing shell scripts from using $! to get definitive pid * joy2key.py: combine disparate lists into a single set of class objects, so related state can no longer get out of sync * joy2key.py: create a _main() function to get things out of global scope * joy2key.py: rename global variables per coding conventions and move them near the top * joy2key.py: comment out the totally broken repeated event filtering (joystick control is now much more responsive) * joy2key.py: simplify timing and tighten up responsiveness by removing/shortening some now-unnecessary sleeps * joy2key.py: restructured and simplified the main loop for clarity and maintainability * helpers.sh, runcommand.sh: stop guessing at the joy2key.py pid using pgrep, and just definitively obtain it via $! * helpers.sh, runcommand.sh: fix functional inconsistencies (use same variable name, use same timings, etc)
…nto joy2key-improvements
|
Sorry - but I am going to have to turn this down for a few reasons. There's a reason we used fork(). Check the source history. You have likely brought back that issue. We used to background via & - your code looks like it reverts to the old behaviour. Your reorganisation of the python isn't where I want to go currently, sorry. But I am aware it needs work, and will note any of your improvements. Thanks. Just to note also: You seem to have multiple commits with fixes for earlier commits. Also merge commits - these are not wanted in PRs in general. It's better to rebase your file changes into logical commits (and squash later fixes into previous changes as needed). |
|
And with that, I am done trying to contribute my talents back to RetroPie. My efforts are clearly neither desired nor appreciated, so I will stop wasting my time trying to help. |
|
Good luck with your bug farm. |
joy2key improvements