fixes jzintv background color to black on pillar boxed 4:3 emulator output and 16:9 displays #3507

Gemba · 2022-04-01T20:58:58Z

sets 4:3 display format for jzintv automagically (launcher file)
fixes a UI freeze bug when a mouse is attached and moved on a RPI3 when jzintv is running

ref: https://retropie.org.uk/forum/topic/32433/jzintv-has-black-border-or-full-screen-color

scriptmodules/emulators/jzintv.sh

cmitu · 2022-04-03T08:30:30Z

scriptmodules/emulators/jzintv.sh

@@ -61,17 +70,60 @@ function install_jzintv() {
 }

 function configure_jzintv() {
-    mkRomDir "intellivision"
+    local system="intellivision"


No need to make system a variable, since it's not changed.

It is more a DRY approach. I don't like to maintain the same information on n locations. But I can remove it or set at least readonly. What is expected the "RetroPie-way"?

Leave it as-is then. A variable is used if the emulator supports multiple systems, but it's not the case here and I'd like that intellivision is explicit for both addSystem and addEmulator.

Ok. I have put it as it was before the PR.

scriptmodules/emulators/jzintv.sh

scriptmodules/emulators/jzintv/01_rpi_pillar_boxing_black_background_sdl2.patch

joolswills · 2022-04-03T15:20:10Z

scriptmodules/emulators/jzintv.sh

+# ingest additional options
+while [[ \$# -gt 1 ]] ; do
+    options+=(\$1); shift
+done


if you have shifted the input params why just do something like options+=("$@")

The jzintv options are "space-free", while the ROM (last parameter) could contain spaces. The last parameter should be quoted to avoid shell interpretation.

I don't see how that wouldn't work with my line above - please can you give an example ?

I condensed it. Didn't notice the quotes in your suggestion initially.

joolswills · 2022-04-03T15:24:06Z

scriptmodules/emulators/jzintv.sh

@@ -27,6 +27,14 @@ function sources_jzintv() {
    # jzintv-YYYYMMDD/ --> jzintv/
    mv jzintv-[0-9]* jzintv
    cd jzintv/src
+    # archive files have CRLF linendings, patch has CR only
+    find . -type f \( -iname "*.c" -o -iname "*.h" \) -exec flip -u {} \+


I'm not sure I like the converting of all the files to LF to apply the patch. Seems overkill. Also do you mean the patches has LF only not CR ?

Well, yes. LF (0x0a) was ment.
Some other options I considered here: Change the source zip archive to LF (hosted at your site, must be remembered when a new source archive is deployed), convert patches to CRLF (awkward as RaspiOS uses UNIX style endings), use --ignore-whitespace in applyPatch (may have knock-on effects).

I had no success when changing the patch line endings. patch hinted to use either --ignore-whitespace or --binary.
I changed it to dos2unix and limited the conversion to the source file which will be patched.

joolswills · 2022-04-03T15:39:48Z

scriptmodules/emulators/jzintv.sh

@@ -44,8 +52,9 @@ function build_jzintv() {
    mkdir -p jzintv/bin
    cd jzintv/src

+    isPlatform "rpi" && local extra='EXTRA=-DPLAT_LINUX_RPI'


You need to declare the variable as local for all platforms not just for the RPI.

I'd like to challenge this. Works also fine when the initial clause is not true.

It may work, but it will mean the variable is used undeclared for non RPI platforms and if the variable had something in it in a parent function that data would be included. So this is not correct.

Ah. Now I understand. Corrected it.

joolswills · 2022-04-03T15:41:37Z

scriptmodules/emulators/jzintv.sh

-    addEmulator 0 "${md_id}-ecs" "intellivision" "$md_inst/bin/jzintv ${options[*]} %ROM%"
-    addSystem "intellivision"
+    addEmulator 1 "$md_id"     "$system" "bash '$start_script' %XRES% %YRES% %ROM%"
+    addEmulator 0 "$md_id-ecs" "$system" "bash '$start_script' %XRES% %YRES% --ecs=1 %ROM%"


The file is marked as executable and lives on a native linux fs so you don't need to use "bash" to run it now.

Right. Leftover from a sample scriptmodule I peeked on unreflected (dosbox.sh).

That's because the script in dosbox is included in $romdir which may be on a fat32 fs so this is needed in that case. As the script is moved now it's not needed here.

joolswills · 2022-04-03T15:43:31Z

scriptmodules/emulators/jzintv.sh

+echo "Launching: \$jzintv_bin \${options[*]} \"\$rom\"" >> /dev/shm/runcommand.log
+
+pushd "$romdir/$system" > /dev/null
+\$jzintv_bin \${options[*]} "\$rom"


If using my example above this would need to be \${options[@]} btw - Unless I'm missing something this should work ok.

see above / intiial comment.

joolswills · 2022-04-03T15:45:15Z

I have made some comments but I'm not sold on including this as it is currently due to the size, and what seems to be unnecessary complexity with the launch script etc.

joolswills · 2022-04-03T15:47:37Z

scriptmodules/emulators/jzintv.sh

@@ -18,7 +18,7 @@ rp_module_section="opt"
 rp_module_flags="sdl2"

 function depends_jzintv() {
-    getDepends libsdl2-dev libreadline-dev
+    getDepends libsdl2-dev libreadline-dev flip


BTW we don't use flip anywhere else. dos2unix is used though so that would be a preference. But you can probably just use sed/tr though to change the files that are needed (or include the patch with CRLF line endings and avoid having to change the source).

Using dos2unix now. See above.

Gemba · 2022-04-04T15:16:57Z

I have made some comments but I'm not sold on including this as it is currently due to the size, and what seems to be unnecessary complexity with the launch script etc.

I guess the launcher size has been reduced already by this review.
A word why I did not patch everything in the source: It would take away the user's option to set a custom resolution and once the border (-b switch in jzintv) function works in jzintv's SDL2 implementation the hard-wiring of a strict maximum (=screen filling) 4:3 jzintv dsiplay may be too limiting.

- sets 4:3 display format for jzintv automagically (launcher file) - fixes a UI freeze bug when a mouse is attached and moved on a RPI3 when jzintv is running ref: https://retropie.org.uk/forum/topic/32433/jzintv-has-black-border-or-full-screen-color

Gemba · 2023-07-08T18:17:19Z

Flipped the content of the patch files as the filename was not reflecting the patch content.

cmitu reviewed Apr 3, 2022

View reviewed changes

Gemba force-pushed the fb_jzintv_16_to_9_bg_fix branch from 52b3f5d to 0f25b67 Compare April 3, 2022 15:02

Gemba requested a review from cmitu April 3, 2022 15:13

joolswills reviewed Apr 3, 2022

View reviewed changes

Gemba force-pushed the fb_jzintv_16_to_9_bg_fix branch from 0f25b67 to 6e149b6 Compare April 4, 2022 14:53

Gemba force-pushed the fb_jzintv_16_to_9_bg_fix branch from 6e149b6 to 19e74bb Compare April 5, 2022 20:21

Gemba force-pushed the fb_jzintv_16_to_9_bg_fix branch from 19e74bb to 1d83718 Compare July 8, 2023 18:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes jzintv background color to black on pillar boxed 4:3 emulator output and 16:9 displays #3507

fixes jzintv background color to black on pillar boxed 4:3 emulator output and 16:9 displays #3507

Gemba commented Apr 1, 2022

cmitu Apr 3, 2022

Gemba Apr 3, 2022

cmitu Apr 3, 2022

Gemba Apr 4, 2022

joolswills Apr 3, 2022

Gemba Apr 3, 2022

joolswills Apr 3, 2022

Gemba Apr 4, 2022

joolswills Apr 3, 2022 •

edited

Gemba Apr 3, 2022

Gemba Apr 4, 2022

joolswills Apr 3, 2022 •

edited

Gemba Apr 3, 2022

joolswills Apr 3, 2022

Gemba Apr 4, 2022

joolswills Apr 3, 2022

Gemba Apr 3, 2022

joolswills Apr 3, 2022

Gemba Apr 4, 2022

joolswills Apr 3, 2022

Gemba Apr 4, 2022

joolswills commented Apr 3, 2022

joolswills Apr 3, 2022 •

edited

Gemba Apr 4, 2022

Gemba commented Apr 4, 2022

Gemba commented Jul 8, 2023

fixes jzintv background color to black on pillar boxed 4:3 emulator output and 16:9 displays #3507

Are you sure you want to change the base?

fixes jzintv background color to black on pillar boxed 4:3 emulator output and 16:9 displays #3507

Conversation

Gemba commented Apr 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joolswills Apr 3, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joolswills Apr 3, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joolswills commented Apr 3, 2022

joolswills Apr 3, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gemba commented Apr 4, 2022

Gemba commented Jul 8, 2023

joolswills Apr 3, 2022 •

edited

joolswills Apr 3, 2022 •

edited

joolswills Apr 3, 2022 •

edited