New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOSBox Staging 0.79 update #3575
Conversation
@nemo93 thanks for the updated script. I've left a few comments on it, looks fine otherwise. One question about the default config - is I'm ok with bumping it from |
@cmitu thanks a lot for your reviews and comments. I've pushed an update to reflect the changes. Also used the opportunity to promote Staging to "opt". If that's an issue please tell me. Regarding Thanks again! |
I've finally managed to build and run on a Pi3 and it works fine (with the default config). One issue I've encountered during building from source is that
@nemo93 did you have any similar issues during building on a Pi3 ? Or did you use the Pi4 for 'cross-compiling' ? |
Another good call. Well I'm the one testing on RPi4 hence no issue while building on that hardware. After checking with the core team member who tests on RPi3, it's definitely known that building on RPi3 takes much longer. Quote: "The big killer on the pi3 is the software scalar which uses a ton of macro-expansions; I remember that file alone takes about 6 minutes to compile w/ -O3 on the pi3, and will soak up a lot of memory." I've edited the script accordingly thanks to your input. There's a PR which will have |
@nemo93 almost there :). I've tested more the
Since
My suggestion is to replace the if isPlatform "kms"; then
iniSet "output" "openglnb"
else
iniSet "output" "texturenb"
fi and this will take care of future OS upgrades in RetroPie, while keeping current (buster) users unaffected. Thanks so much for the support, sorry for nitpicking. |
@cmitu please keep on nitpicking! This is quite useful and helps to improve Staging. Thanks a lot for that. I've added your condition based on Pi model. I was unsure about the best style hence shout if not fine. Also this PR is not ready yet to be merged in as the PR improving the "resources dir" handling is still in review. I'll give you a nudge once it's there. @joolswills anytime. It's a breeze thanks to @cmitu excellent testing and feedback. |
@nemo93 thank you for the changes, they're fine. |
Thanks again for all testing and feedback. The upcoming |
@cmitu Thanks again for the time, testing and feedback. |
@nemo93 that was fast :). Re-tested again the installations and it's ok now, no more hiccups on the Pi3. Should be ready to merge (nudge @joolswills).
Hah, from a cursory look it seems the mappings have the Start + Select set to exit the emulator ? If yes, that's neat. |
That's right. Objective was to mimick the Retropie/Retroarch combo. |
Anything else I should do/you're expecting from me? Thanks! |
@nemo93 no, it's fine. |
Thanks everyone. |
This new version failed to build on the Raspberry Pi 1 due to the speexdsp meson wrap defaulting to enabling simd (neon). See #3590 |
Just a heads up: this doesn't work OOTB on Ubuntu 18.04. The newest version of The error, specifically:
Not sure if the latest |
Just to add to my comment above, I also had to disable OpenGL support via:
After that, the scriptmodule built fine on ODROID XU4 w/ Ubuntu 18.04. I suspect the OpenGL issue is an ODROID XU4-specific one (the vendor files are wonky, maybe? no idea). Could not find an obvious way to get it to work with OpenGL enabled. At least it builds without it, though. Regarding the Meson issue: looks like it probably wouldn't build on 20.04 either, since the Finally, sorry for the thread necromancy. I will stop now :). |
Full changelogs:
TL;DR: many improvements done on the audio front where the SB16 will now sound exactly as it's supposed to, compressor to prevent clipping, etc. Inclusion of a nice mouse driver for Windows 3.1. Performance improvement for low-spec devices (eg. RPi) and other graphical improvements (CGA, shaders, etc). Localization improvements. xbox-compatible controller mapperfiles for 180+ games.
All credits to DOSBox' community and of course to the many excellent contributors of Staging.
Script updated to include new required files and better default values for RPi3/4 devices.
libspeexdsp-dev
has been added as a new dependency.resources
.