Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mupen64plus.sh: update GlideN64 config version #3653

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

gizmo98
Copy link
Member

@gizmo98 gizmo98 commented Mar 3, 2023

GlideN64 overwrites settings if config version is to old. Current config version is 29. https://github.com/gonetz/GLideN64/blob/1f4d04f43b53739bc9b128ab5577d20e3d60ed6a/src/Config.h#L8

@joolswills
Copy link
Member

joolswills commented Mar 3, 2023

We also have a default in https://github.com/RetroPie/RetroPie-Setup/blob/master/scriptmodules/emulators/mupen64plus/mupen64plus.sh#L253 (Which is overridden by this).

I think we should extract this from the source and copy it to $md_inst for use at the configure stage.

from:
https://github.com/gonetz/GLideN64/blob/1f4d04f43b53739bc9b128ab5577d20e3d60ed6a/src/Config.h#L8

I can look into this if you like. Will save us from having to keep this up to date.

@joolswills
Copy link
Member

I'll merge this - but will look into a solution for managing this automatically.

@joolswills joolswills merged commit 27bdc39 into RetroPie:master Mar 3, 2023
@joolswills
Copy link
Member

Thanks.

@joolswills
Copy link
Member

Would of course be easier if upstream didn't overwrite it each time - I understand backward compatibility issues, but it would be a lot simpler. It's quite an unusual way of dealing with it to overwrite if the version doesn't match I think.

@gizmo98 gizmo98 deleted the Gliden64-ConfigVersion branch March 7, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants