Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added default theme in support of collections feature #32

Merged
merged 1 commit into from Jul 8, 2017
Merged

added default theme in support of collections feature #32

merged 1 commit into from Jul 8, 2017

Conversation

jrassa
Copy link
Contributor

@jrassa jrassa commented Jul 8, 2017

Uses the new theme variables features to provide a default theme that will be used when no system specific theme exists. This will support the new collections feature (favorites, recent, all games).

The default theme must be the root theme.xml file. Previous version of this file was not being used and only existed as an example.

This change should not effect existing users who have not updated EmulationStation. Changes only effect the default theme, which will not be loaded for those users.

@pjft
Copy link
Contributor

pjft commented Jul 8, 2017

Thank you - this works surprisingly well!

My only comment is that "Favorites" when selected gets shortened to "FAVORI..." on the carousel. Maybe if the font-size is smaller that's sorted, though I don't know if that's something we can change.

A separate question: is there a way to detect that a theme has a default theme defined in ES via code?

Thanks!

@joolswills joolswills merged commit aad1e0e into RetroPie:master Jul 8, 2017
@joolswills
Copy link
Member

Thanks.

@jrassa
Copy link
Contributor Author

jrassa commented Jul 9, 2017

@pjft setting the font-size for the logo text isn't currently supported. I have some other changes that I have been working on for the carousel so I will try to include it with them.

The default theme is implemented by having a theme.xml file in the root of the theme directory. You should be able to check for the existence of the that file. However, there are a couple of themes where that file already exists. I have most of the themes available from RetroPie-Setup on my dev box so I checked them. carbon and minilumi use it as an example and would cause a false positive. crt, crt-tft and nbba use it as their base theme file, that the system themes import. This is actually beneficial, since they work as a default theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants