New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config network #76
Config network #76
Conversation
Added feature to set - dynamic DNS - set i2p/tor socks proxy Fixed some UI issues Refactored Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
Thanks to you, And I had a question about mithril.js. After researching, I found that, Is there any way to do it, so we could make the code more reusable and reduce the number of data fetching? @rottencandy |
Mithril has an automatic redrawing system that should trigger rerender once any m.request promise chain completes (which is what rsJsonApiRequest is using) but looks like in this case you're making nested calls so that might be the reason. m.stream seems to be a separate package so you'll have to add it separately if you want to use it. But I'm not entirely sure if nested calls is the reason, I'll also try to reproduce this and see if I can figure out what's happening. |
I had already tried promise-chaining + manual rerender with m.redraw(). But It didn't work. |
Added features to set Dynamic DNS, configure TOR/I2P SOCKS Proxy from the webui.
Fixed some UI issues and refactored code.
Some issues are still there but not from webui, they need to be fixed/implemented on the libretroshare, probably.