V0.6 short invites #1571

csoler · 2019-05-28T20:41:16Z

WIP: short invites. GUI part is on its way.

Short invites support for libretroshare

…ks for consistency

…yet)

G10h4ck · 2019-06-20T21:36:56Z

libretroshare/src/rsserver/p3peers.cc

@@ -1342,6 +1344,7 @@ bool p3Peers::parseShortInvite(const std::string& inviteStrUrl, RsPeerDetails& d
 		default:
 			RsWarn() << __PRETTY_FUNCTION__ << " got unkown field type: "
 			         << static_cast<uint32_t>(fieldType) << std::endl;
+            return false;


In case we get an unknown field we should just print a warning and ignore it, just in case we decide to add some new field in newer versions, so we can stay compatible with the past versions. Did you remember we had to do the same change on old certs? Maybe we need to add filed length too for achieving that?

I agree on the principle. In this case I had an invite that did not parse and therefore the parser is actually going through the entire data byte by byte. This is the consequence of not storing the size of each field (which we actually do in RS certificate format) in which case it's more easy to distinguish random data (that has inconsistent size) from correct field with unknown tag (that has consistent size). So it seems to me that because we cannot decide, it's safer to return false otherwise, when parsing random data you'd easily end up with a random supposedly valid SSL id and PGP fingerprint.

Another way to see the problem is that if you have 1 unknown field in the middle of the invite, the parser will not be able to skip it. It will instead try to interpret each and every byte in this field as a potential tag. That's likely to make the parsing completely wrong and even prevent the correct reading of the remaining fields. It seems to me that it would be safer to add sizes (which is 1 byte most of the time in the 1-2-5 encoding).

…able yet

…ature_validation

csoler · 2019-09-19T19:20:00Z

This PR needs to be tested. See internal devs forums. Do not trust the security of this PR. It's to be considered flawed until proven otherwise.

defnax · 2019-09-20T16:09:59Z

short invites key great, but the real easy send/accept friend request will never come to rs?
Two side must copy and paste the keys to get be friends ?

- no discovery information is exchanged with nodes with short invites before the public PGP key has been received.

If i click accept request, then it must be have a feature to send the key to other site, that will not come?

G10h4ck · 2019-09-21T12:33:32Z

IMHO the possibility to add someone as friend on attempt is a really important usability feature, even in one of the most common social interaction people ask your phone number, and then give you a miss call so you have their number instead of blabbering it to you...

So I have double checked the code, and it is still possible to implement an accept button after a failed connection attempt notification at user interface level.

I have explained the details on a way to implement that in #638
But I think that proposal (only UI work) should be eventually implemented in another PR after this one is merged.

G10h4ck · 2019-09-21T13:21:02Z

libretroshare/src/pqi/authssl.cc

@@ -1198,6 +1198,21 @@ int AuthSSLimpl::VerifyX509Callback(int /*preverify_ok*/, X509_STORE_CTX* ctx)
 	std::string sslCn = RsX509Cert::getCertIssuerString(*x509Cert);
 	RsPgpId pgpId(sslCn);

+    RsPeerDetails det;
+    if(!rsPeers->getPeerDetails(sslId,det))


This extra check deny connection to a new location of a PGP friend, IMHO we should remove it

G10h4ck · 2019-09-21T13:23:03Z

libretroshare/src/pqi/authssl.cc

+
+	bool isSslOnlyFriend = det.skip_pgp_signature_validation;
+
+    if(det.gpg_id != pgpId)


This extra check deny connection to a new location of a PGP friend, IMHO we should remove it. PGP-id matching is correctly done at line 1275.

not at all, because it should have the same PGP id.

the problem is that det is not populated if sslid is not known

… ability to accept fingerprint instead of ID in the handshake

G10h4ck · 2019-09-21T17:04:53Z

libretroshare/src/pqi/authssl.cc

-		         << ", Version " << std::hex << certificate_version << std::dec
-		         << " using PGP key " << pd.fpr << " " << pd.name << std::endl;
+        if(verbose)
+			std::cerr<< " Verified: " << sigtypestring


Please keep RsInfo() << __PRETTY_FUNCTION__ instead of std::cerr

Well, here I removed it because it prints too much. We don't need the time nor the function name.

If you don'T want the function name just keep RsInfo() at least it will print well on all platforms, plain std::cXXX doesn't work on Android so I had to do a dirty trick to be able to get those messages too, but it doesn'T wok always, while if you use the thins defined in util/rsdebug.h it works well on all platforms

…herwise the call to isGPGAccepted() will rule out wrong IDs anyway

libretroshare/src/pqi/authssl.cc

…eeded anymore

defnax · 2019-09-23T12:21:15Z

I have explained the details on a way to implement that in #638
But I think that proposal (only UI work) should be eventually implemented in another PR after this one is merged.

that would be great

defnax · 2019-09-24T22:50:04Z

hi gui part need/must look now more simple
we can remove the big cert view from Home ?
best use Retroshare ID or Short ID?

QR Code comes too`? maybe a button to view the QR image

Did you received a Retroshare ID from friend? Add friend (Button)

This is your RetroShare ID. Copy and share with your friends!

look on screenshot on jami looks very simple

unsenep2pdev · 2019-09-24T23:14:41Z

You can try out our pre-release Unseen Communicator based on RS: https://communicator.unseen.is/ <https://communicator.unseen.is/>

…

On Sep 24, 2019, at 3:50 PM, defnax ***@***.***> wrote: hi gui part need/must look now more simpler we can remove the big cert view from Home ? best use Retroshare ID or Short ID? QR Code comes too`? maybe a button to view the QR image Did you received a Retroshare ID from friend? Add friend (Buttom) This is your RetroShare ID share with your friends! look on screenshot on jami looks very simple <https://user-images.githubusercontent.com/9952056/65555206-2db67c80-df2c-11e9-9d43-5cbcda5363b3.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1571?email_source=notifications&email_token=AKI7WPRN7KM2AKNEPFBB2X3QLKKSBA5CNFSM4HQG5PO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7QBCSY#issuecomment-534778187>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKI7WPVRV7JWPRO5BZRLUCLQLKKSBANCNFSM4HQG5POQ>.

csoler · 2019-09-25T07:08:05Z

@defnax : I agree to simplify the Home panel as much as possible. The example you give here is very nice. However, it's important to keep the possibility to use long certs for backward compatibility, at least for a few months.

G10h4ck · 2019-09-25T10:15:27Z

Also please keep all that GUI work into another PR, so we can merge this ASAP without reviewing the code again and again

csoler · 2019-09-25T11:00:05Z

@G10h4ck: of course.

defnax · 2019-09-25T14:10:58Z

You can try out our pre-release Unseen Communicator based on RS: https://communicator.unseen.is/ https://communicator.unseen.is/

Hi, i always posted your fork on RetroShare Forums, you need to look there, i know since last year about Unseen :)
@unsenep2pdev You are not active on RetroShare network?

G10h4ck and others added 6 commits May 16, 2019 22:13

Implement libretroshare short invites support

720d5ea

Fix windows compilation

bde6235

Merge pull request RetroShare#1565 from G10h4ck/short_invites_v2

dac7643

Short invites support for libretroshare

added a flag in peerState specific to short invites, and several chec…

56e591f

…ks for consistency

fixed uninitialized memory read for variable mRsEventsHandle

4eb6b0b

fixed stupid bug that crashed the code in a different place

8fddb55

G10h4ck added the elrepo.io issues related to elrepo.io usecase label May 29, 2019

added optional display of short invites in places with certificates

3a799ba

csoler changed the title ~~V0.6 short invites~~ [WIP] V0.6 short invites Jun 6, 2019

csoler added 15 commits June 9, 2019 15:03

added parsing of short invites in connect friend wizard (not working …

4bd5aaa

…yet)

fixed up addign friend from short invite

fb52f67

fixed compilation

76cf64f

removed unused startWizard and loadCert code in HomePage

a7141cb

removed unused intro page from ConnectFriendWizard

6294aef

removed unused RsId and Fof pages from ConnectFriendWizard

0c510a5

removed unused Email page from ConnectFriendWizard

c0436b7

removed unused FriendRequest page from ConnectFriendWizard

a55e824

removed unused Cert page from ConnectFriendWizard

a04079d

removed unused Cert page from ConnectFriendWizard

1f56ef3

removed unused Cert page from ConnectFriendWizard

38434f2

fixed adding friend with short invite

57a5485

fixed parsing of short invite

805f753

removed CIRCLES-related dead code from friendlist

6114d97

attempt to add SSL-only friends in FriendList - does not work yet

e132ce7

G10h4ck requested changes Jun 20, 2019

View reviewed changes

csoler added 5 commits June 21, 2019 23:30

converted short invites to compact PGP format for increased robustness

9312d0c

moved SSL part of friend list into a separate function

a52451b

arranged to show PGP id for friends from short invite. Name not avail…

daec6b3

…able yet

merged upstream/master

6419b03

fixed missing type conversion

dd90314

csoler added 2 commits September 19, 2019 20:59

fixed comments from review of PR

654d760

renamed skip_signature_validation into more appropriate skip_pgp_sign…

4fabf3d

…ature_validation

csoler changed the title ~~[WIP] V0.6 short invites~~ [Test needed] V0.6 short invites Sep 19, 2019

G10h4ck mentioned this pull request Sep 21, 2019

Implement New Invite System #638

Open

G10h4ck requested changes Sep 21, 2019

View reviewed changes

removed some debug info about PGP signature validation, and added the…

ed864f9

… ability to accept fingerprint instead of ID in the handshake

G10h4ck requested changes Sep 21, 2019

View reviewed changes

restricted check for matching PGP ids to short invites only, since ot…

6919711

…herwise the call to isGPGAccepted() will rule out wrong IDs anyway

G10h4ck requested changes Sep 21, 2019

View reviewed changes

libretroshare/src/pqi/authssl.cc Outdated Show resolved Hide resolved

csoler added 5 commits September 22, 2019 16:34

fixed bug caused by shadowing a variable

9c7edff

fixed bug caused by wrong reading of disc flag

19ced52

used RsInfo instead of std::cerr in authssl.cc

9b78447

removed dependency of FriendDialog on RsAutoUpdatePage which is not n…

cdeee01

…eeded anymore

added missing notifications when adding friends

282d2d3

csoler added 3 commits September 23, 2019 19:44

fixed wrong default value for showUnconnected nodes

a04d56e

removed some dead code

d055887

removed unused mOthersList from PeerMgr

24781a7

G10h4ck merged commit 5acb6c2 into RetroShare:master Sep 25, 2019

G10h4ck changed the title ~~[Test needed] V0.6 short invites~~ V0.6 short invites Sep 25, 2019

defnax mentioned this pull request Nov 20, 2019

[Qt] RetroShare ID [short invites] is done but the Accept/Reject Friend Request on Gui is missed #1709

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V0.6 short invites #1571

V0.6 short invites #1571

csoler commented May 28, 2019

G10h4ck Jun 20, 2019

csoler Jun 21, 2019

csoler Jun 21, 2019

csoler commented Sep 19, 2019

defnax commented Sep 20, 2019

G10h4ck commented Sep 21, 2019

G10h4ck Sep 21, 2019

G10h4ck Sep 21, 2019

csoler Sep 21, 2019

G10h4ck Sep 21, 2019

G10h4ck Sep 21, 2019

csoler Sep 21, 2019

G10h4ck Sep 21, 2019

defnax commented Sep 23, 2019

defnax commented Sep 24, 2019 •

edited

unsenep2pdev commented Sep 24, 2019 via email

csoler commented Sep 25, 2019

G10h4ck commented Sep 25, 2019

csoler commented Sep 25, 2019

defnax commented Sep 25, 2019


		bool isSslOnlyFriend = det.skip_pgp_signature_validation;

		if(det.gpg_id != pgpId)

V0.6 short invites #1571

V0.6 short invites #1571

Conversation

csoler commented May 28, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

csoler commented Sep 19, 2019

defnax commented Sep 20, 2019

G10h4ck commented Sep 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

defnax commented Sep 23, 2019

defnax commented Sep 24, 2019 • edited

Did you received a Retroshare ID from friend? Add friend (Button)

This is your RetroShare ID. Copy and share with your friends!

unsenep2pdev commented Sep 24, 2019 via email

csoler commented Sep 25, 2019

G10h4ck commented Sep 25, 2019

csoler commented Sep 25, 2019

defnax commented Sep 25, 2019

defnax commented Sep 24, 2019 •

edited